Tap on the menus always turns into a click (->page load).
<rdar://problem/45792118>
Created attachment 356212 [details] Patch
Attachment 356212 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:40: Extra space between bool and _WKObservingStyleRecalScheduling [whitespace/declaration] [3] ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:40: _WKObservingStyleRecalScheduling is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:41: Extra space between bool and _WKObservingNextStyleRecalc [whitespace/declaration] [3] ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:41: _WKObservingNextStyleRecalc is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 356212 [details] Patch r=me platform/ios/wak is so weird!
Comment on attachment 356212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356212&action=review > LayoutTests/fast/events/touch/ios/hover-when-style-change-is-async-expected.txt:1 > +PASS if NOT clicked. This is a pretty confusing pass result. It should read "PASS: did not send a click when blah....."
Created attachment 356247 [details] Patch
Attachment 356247 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:40: Extra space between bool and _WKObservingStyleRecalScheduling [whitespace/declaration] [3] ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:40: _WKObservingStyleRecalScheduling is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:41: Extra space between bool and _WKObservingNextStyleRecalc [whitespace/declaration] [3] ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:41: _WKObservingNextStyleRecalc is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 356247 [details] Patch Clearing flags on attachment: 356247 Committed r238759: <https://trac.webkit.org/changeset/238759>
All reviewed patches have been landed. Closing bug.