Bug 192222 - [WebGPU] Add scaffolding to parse WHLSL shaders
Summary: [WebGPU] Add scaffolding to parse WHLSL shaders
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-29 23:03 PST by Myles C. Maxfield
Modified: 2018-12-20 16:44 PST (History)
9 users (show)

See Also:

Attachments
Patch (19.33 MB, patch)
2018-11-29 23:13 PST, Myles C. Maxfield 		mmaxfield: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-11-29 23:03:58 PST 
[WebGPU] Add scaffolding to parse WHLSL shaders
Comment 1 Myles C. Maxfield 2018-11-29 23:13:08 PST 
Created attachment 356148 [details]
Patch
Comment 2 Myles C. Maxfield 2018-11-29 23:16:52 PST 
This doesn't build ANTLR from source; instead, it just checks in the precompiled runtime and parser generator tool. We can use them out-of-the-box, so I don't think it's necessary to waste everyone's time building them.
Comment 3 Dean Jackson 2018-11-30 09:40:54 PST 
I can't seem to get the "Review Patch" page to work with such a big patch, so I'll comment here.

- do we have permission from legal to include this 3rd party tool?
- would it be better to start with a result generated offline, before including the tool?
Comment 4 Myles C. Maxfield 2018-11-30 12:00:10 PST 
(In reply to Dean Jackson from comment #3)
> I can't seem to get the "Review Patch" page to work with such a big patch,
> so I'll comment here.
> 
> - do we have permission from legal to include this 3rd party tool?

Do we need to? It's using the BSD license.

> - would it be better to start with a result generated offline, before
> including the tool?

The tool is written in Java and the bots don't have Java installed so we're either going to have to install Java on the bots and all the WebKit dev's machines or do what you propose. (Or not use ANTLR)