This avoids the "confusion" around left/right quotes.
<rdar://problem/46275637>
Created attachment 356131 [details] Patch
There are still some unicode characters in: - UserInterface/External/CodeMirror/codemirror.js - UserInterface/External/Esprima/esprima.js - UserInterface/External/three.js/LICENSE - UserInterface/External/three.js/three.js - UserInterface/Images/*.svg
Comment on attachment 356131 [details] Patch Attachment 356131 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10210121 New failing tests: inspector/audit/data-domNodes.html inspector/audit/data-domAttributes.html inspector/audit/data-errors.html
Created attachment 356141 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 356131 [details] Patch Attachment 356131 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10210269 New failing tests: inspector/audit/data-domNodes.html inspector/audit/data-domAttributes.html inspector/audit/data-errors.html
Created attachment 356143 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 356131 [details] Patch Attachment 356131 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10210432 New failing tests: inspector/audit/data-domNodes.html inspector/audit/data-domAttributes.html inspector/audit/data-errors.html
Created attachment 356150 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 356161 [details] Patch
Comment on attachment 356161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356161&action=review r=me This will cause a lot of churn for localizers, but it's probably better that the current state of things considering that our code review tools don't render unicode correctly. > Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css:178 > + content: "\00A0\2014\00A0"; Please keep the comment. > Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.js:58 > + span.textContent = ` ${emDash} `; Nice. > Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.css:52 > } I'm not sure what these codepoints do. I would like a comment when its something fairly unique. > Source/WebInspectorUI/UserInterface/Views/TextEditor.css:78 > + content: "\2022\2022\2022"; Ditto > Source/WebInspectorUI/UserInterface/Views/TreeOutline.css:256 > } Ditto
Created attachment 356191 [details] Patch
I’m really not a fan of this change. I can’t read strings in the code anymore. (In reply to Devin Rousso from comment #0) > This avoids the "confusion" around left/right quotes. Can we only do this for quotes?
Comment on attachment 356191 [details] Patch Clearing flags on attachment: 356191 Committed r238743: <https://trac.webkit.org/changeset/238743>
All reviewed patches have been landed. Closing bug.