Bug 192206 - Inform clients when editable image attachment backing data changes
Summary: Inform clients when editable image attachment backing data changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-29 18:11 PST by Tim Horton
Modified: 2018-11-29 22:31 PST (History)
8 users (show)

See Also:


Attachments
Patch (21.20 KB, patch)
2018-11-29 18:11 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (21.46 KB, patch)
2018-11-29 22:03 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-11-29 18:11:02 PST
Inform clients when editable image attachment backing data changes
Comment 1 Tim Horton 2018-11-29 18:11:21 PST
Created attachment 356102 [details]
Patch
Comment 2 Tim Horton 2018-11-29 18:11:23 PST
<rdar://problem/46350277>
Comment 3 EWS Watchlist 2018-11-29 18:13:53 PST
Attachment 356102 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/ios/PencilKitTestSPI.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Wenson Hsieh 2018-11-29 18:24:58 PST
Comment on attachment 356102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356102&action=review

> Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm:67
> +    m_webPage->didInvalidateDataForAttachment(*this);

Should we also notify the delegate when Attachment::setFileWrapperGenerator invalidates the file wrapper?
Comment 5 Tim Horton 2018-11-29 22:03:43 PST
Created attachment 356133 [details]
Patch
Comment 6 EWS Watchlist 2018-11-29 22:06:46 PST
Attachment 356133 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/ios/PencilKitTestSPI.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2018-11-29 22:31:13 PST
Comment on attachment 356133 [details]
Patch

Clearing flags on attachment: 356133

Committed r238726: <https://trac.webkit.org/changeset/238726>
Comment 8 WebKit Commit Bot 2018-11-29 22:31:14 PST
All reviewed patches have been landed.  Closing bug.