RESOLVED FIXED 192203
[JSC] Keep TypeMaybeBigInt small 
https://bugs.webkit.org/show_bug.cgi?id=192203
Summary [JSC] Keep TypeMaybeBigInt small
Yusuke Suzuki
Reported 2018-11-29 17:01:29 PST
[JSC] Keep TypeMaybeBigInt small
Attachments
Patch (2.64 KB, patch)
2018-11-29 17:06 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-11-29 17:06:22 PST
Created attachment 356097 [details] Patch
Caio Lima
Comment 2 2018-11-30 04:56:30 PST
Informal review here. LGTM.
Yusuke Suzuki
Comment 3 2018-11-30 21:04:16 PST
Ping?
Saam Barati
Comment 4 2018-12-01 00:21:10 PST
Comment on attachment 356097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356097&action=review > Source/JavaScriptCore/parser/ResultType.h:35 > + static constexpr Type TypeInt32 = 0x1 << 0; style nit: i’m not sure if this is a UI issue in bugzilla, but this line is the only line without the “=“ lined up. We should align it
Yusuke Suzuki
Comment 5 2018-12-01 00:36:58 PST
Comment on attachment 356097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356097&action=review Thank you! >> Source/JavaScriptCore/parser/ResultType.h:35 >> + static constexpr Type TypeInt32 = 0x1 << 0; > > style nit: i’m not sure if this is a UI issue in bugzilla, but this line is the only line without the “=“ lined up. We should align it It seems that this is UI issue. This `=` is aligned to the other ones actually :)
Yusuke Suzuki
Comment 6 2018-12-01 00:38:57 PST
Committed r238778: <https://trac.webkit.org/changeset/238778>
Radar WebKit Bug Importer
Comment 7 2018-12-01 00:39:29 PST
<rdar://problem/46394250>
Guillaume Emont
Comment 8 2018-12-03 03:37:26 PST
*** Bug 192152 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.