Bug 192203 - [JSC] Keep TypeMaybeBigInt small
Summary: [JSC] Keep TypeMaybeBigInt small
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 192152 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-11-29 17:01 PST by Yusuke Suzuki
Modified: 2018-12-03 03:37 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2018-11-29 17:06 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-11-29 17:01:29 PST 
[JSC] Keep TypeMaybeBigInt small
Comment 1 Yusuke Suzuki 2018-11-29 17:06:22 PST 
Created attachment 356097 [details]
Patch
Comment 2 Caio Lima 2018-11-30 04:56:30 PST 
Informal review here. LGTM.
Comment 3 Yusuke Suzuki 2018-11-30 21:04:16 PST 
Ping?
Comment 4 Saam Barati 2018-12-01 00:21:10 PST 
Comment on attachment 356097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356097&action=review

> Source/JavaScriptCore/parser/ResultType.h:35
> +        static constexpr Type TypeInt32       = 0x1 << 0;

style nit: i’m not sure if this is a UI issue in bugzilla, but this line is the only line without the “=“ lined up. We should align it
Comment 5 Yusuke Suzuki 2018-12-01 00:36:58 PST 
Comment on attachment 356097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356097&action=review

Thank you!

>> Source/JavaScriptCore/parser/ResultType.h:35
>> +        static constexpr Type TypeInt32       = 0x1 << 0;
> 
> style nit: i’m not sure if this is a UI issue in bugzilla, but this line is the only line without the “=“ lined up. We should align it

It seems that this is UI issue. This `=` is aligned to the other ones actually :)
Comment 6 Yusuke Suzuki 2018-12-01 00:38:57 PST 
Committed r238778: <https://trac.webkit.org/changeset/238778>
Comment 7 Radar WebKit Bug Importer 2018-12-01 00:39:29 PST 
<rdar://problem/46394250>
Comment 8 Guillaume Emont 2018-12-03 03:37:26 PST 
*** Bug 192152 has been marked as a duplicate of this bug. ***