Bug 192189 – Web Inspector: Canvas: add singular localized string for "Record first %s frames"

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

When the auto-capture frame count is 1, "Record first 1 frames" is grammatically weird.  It should be "Record first 1 frame".

[Devin Rousso]

Created attachment 356071 [details]
Patch

[Devin Rousso]

<rdar://problem/46274398>

[Joseph Pecoraro]

Comment on attachment 356071 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 356071 [details]
Patch

Rejecting attachment 356071 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 356071, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=356071&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192189&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 356071 from bug 192189.
Fetching: https://bugs.webkit.org/attachment.cgi?id=356071
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
Hunk #1 FAILED at 356.
Hunk #2 succeeded at 700 (offset -1 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js.rej
patching file Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js
patching file Source/WebInspectorUI/UserInterface/Views/CheckboxNavigationItem.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10252149

[Devin Rousso]

Created attachment 356425 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 356425 [details]
Patch

Clearing flags on attachment: 356425

Committed r238829: <https://trac.webkit.org/changeset/238829>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.