Bug 192183 - [ContentObservation] Make WKSetObservedContentChange logic more explicit
Summary: [ContentObservation] Make WKSetObservedContentChange logic more explicit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-29 14:56 PST by zalan
Modified: 2018-11-29 15:09 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.27 KB, patch)
2018-11-29 14:58 PST, zalan
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-11-29 14:56:41 PST
ssia
Comment 1 zalan 2018-11-29 14:58:51 PST
Created attachment 356062 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-11-29 15:03:47 PST
Comment on attachment 356062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356062&action=review

> Source/WebCore/platform/ios/wak/WKContentObservation.cpp:82
> +    if (_WKContentChange == WKContentVisibilityChange)

Would be nice if the enum were ordered so you could do a > check here.
Comment 3 zalan 2018-11-29 15:08:32 PST
Committed r238699: <https://trac.webkit.org/changeset/238699>
Comment 4 Radar WebKit Bug Importer 2018-11-29 15:09:34 PST
<rdar://problem/46355931>