Bug 192182 - [MediaStream] DeviceIdHashSaltStorage should use iframe and top level documents
Summary: [MediaStream] DeviceIdHashSaltStorage should use iframe and top level documents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-29 14:41 PST by Eric Carlson
Modified: 2018-11-29 19:15 PST (History)
3 users (show)

See Also:

Attachments
Patch (17.60 KB, patch)
2018-11-29 14:48 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing. (18.16 KB, patch)
2018-11-29 18:47 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-11-29 14:41:56 PST 
DeviceIdHashSaltStorage should use iframe and top level documents
Comment 1 Radar WebKit Bug Importer 2018-11-29 14:42:29 PST 
<rdar://problem/46354914>
Comment 2 Eric Carlson 2018-11-29 14:48:44 PST 
Created attachment 356061 [details]
Patch
Comment 3 youenn fablet 2018-11-29 15:34:11 PST 
Comment on attachment 356061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356061&action=review

> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:83
>  void DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins(const Vector<SecurityOriginData>& origins, CompletionHandler<void()>&& completionHandler)

We probably need to update getDeviceIdHashSaltOrigins to also add the topOrigin to origins.

> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.h:50
> +            : documentOrigin(documentOrigin)

WTFMove(documentOrigin) and WTFMove(parentOrigin)
Comment 4 Eric Carlson 2018-11-29 18:44:08 PST 
Comment on attachment 356061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356061&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:83
>>  void DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins(const Vector<SecurityOriginData>& origins, CompletionHandler<void()>&& completionHandler)
> 
> We probably need to update getDeviceIdHashSaltOrigins to also add the topOrigin to origins.

Good point, fixed.

>> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.h:50
>> +            : documentOrigin(documentOrigin)
> 
> WTFMove(documentOrigin) and WTFMove(parentOrigin)

Fixed.
Comment 5 Eric Carlson 2018-11-29 18:47:42 PST 
Created attachment 356105 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2018-11-29 19:15:11 PST 
Comment on attachment 356105 [details]
Patch for landing.

Clearing flags on attachment: 356105

Committed r238724: <https://trac.webkit.org/changeset/238724>
Comment 7 WebKit Commit Bot 2018-11-29 19:15:13 PST 
All reviewed patches have been landed.  Closing bug.