Bug 192182 – [MediaStream] DeviceIdHashSaltStorage should use iframe and top level documents

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Eric Carlson]

DeviceIdHashSaltStorage should use iframe and top level documents

[Radar WebKit Bug Importer]

<rdar://problem/46354914>

[Eric Carlson]

Created attachment 356061 [details]
Patch

[youenn fablet]

Comment on attachment 356061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356061&action=review

> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:83
>  void DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins(const Vector<SecurityOriginData>& origins, CompletionHandler<void()>&& completionHandler)

We probably need to update getDeviceIdHashSaltOrigins to also add the topOrigin to origins.

> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.h:50
> +            : documentOrigin(documentOrigin)

WTFMove(documentOrigin) and WTFMove(parentOrigin)

[Eric Carlson]

Comment on attachment 356061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356061&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:83
>>  void DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins(const Vector<SecurityOriginData>& origins, CompletionHandler<void()>&& completionHandler)
> 
> We probably need to update getDeviceIdHashSaltOrigins to also add the topOrigin to origins.

Good point, fixed.

>> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.h:50
>> +            : documentOrigin(documentOrigin)
> 
> WTFMove(documentOrigin) and WTFMove(parentOrigin)

Fixed.

[Eric Carlson]

Created attachment 356105 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 356105 [details]
Patch for landing.

Clearing flags on attachment: 356105

Committed r238724: <https://trac.webkit.org/changeset/238724>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.