Bug 192179 - [WebGPU] Replace forward declare of WebGPUCommandBuffer with include
Summary: [WebGPU] Replace forward declare of WebGPUCommandBuffer with include
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-29 14:04 PST by Justin Fan
Modified: 2018-11-29 15:19 PST (History)
3 users (show)

See Also:

Attachments
Patch for landing (1.99 KB, patch)
2018-11-29 14:13 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-11-29 14:04:44 PST 
[WebGPU] Replace forward declare of WebGPUCommandBuffer with include
Comment 1 Justin Fan 2018-11-29 14:13:00 PST 
Created attachment 356058 [details]
Patch for landing
Comment 2 WebKit Commit Bot 2018-11-29 15:02:07 PST 
The commit-queue encountered the following flaky tests while processing attachment 356058 [details]:

sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.4_encodeURIComponent/S15.1.3.4_A2.3_T1.html bug 192186 (authors: jamesr@chromium.org and rniwa@webkit.org)
webgl/2.0.0/conformance/more/functions/texImage2DHTML.html bug 192187 (author: justin_fan@apple.com)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2018-11-29 15:02:15 PST 
The commit-queue encountered the following flaky tests while processing attachment 356058 [details]:

webgl/1.0.2/conformance/more/functions/uniformfBadArgs.html bug 192188 (author: roger_fong@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2018-11-29 15:18:46 PST 
Comment on attachment 356058 [details]
Patch for landing

Clearing flags on attachment: 356058

Committed r238700: <https://trac.webkit.org/changeset/238700>
Comment 5 WebKit Commit Bot 2018-11-29 15:18:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-29 15:19:46 PST 
<rdar://problem/46356261>