webkitpy: Unify device creation

[Jonathan Bedard]

The API for creating simulated devices and physical devices is identical. We should leverage this fact and create all devices in the DevicePort class.

[Radar WebKit Bug Importer]

<rdar://problem/46344757>

[Jonathan Bedard]

Created attachment 356031 [details]
Patch

[Lucas Forschler]

Comment on attachment 356031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356031&action=review

lgtm with typo fix

> Tools/Scripts/webkitpy/port/device_port.py:130
> +            raise RuntimeError('Not enought connected devices for {} processes'.format(self.child_processes()))

nit: typo enough

[Simon Fraser (smfr)]

Comment on attachment 356031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356031&action=review

>> Tools/Scripts/webkitpy/port/device_port.py:130
>> +            raise RuntimeError('Not enought connected devices for {} processes'.format(self.child_processes()))
> 
> nit: typo enough

That should read "too few connected devices". Can this error fire for simulators?

[Jonathan Bedard]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 356031 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356031&action=review
> 
> >> Tools/Scripts/webkitpy/port/device_port.py:130
> >> +            raise RuntimeError('Not enought connected devices for {} processes'.format(self.child_processes()))
> > 
> > nit: typo enough
> 
> That should read "too few connected devices". Can this error fire for
> simulators?

No, it cannot. Simulators will boot enough devices to match the number specified.

[Jonathan Bedard]

Created attachment 356042 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 356042 [details]
Patch for landing

Clearing flags on attachment: 356042

Committed r238694: <https://trac.webkit.org/changeset/238694>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.