Bug 192150 – [GTK] Four xhr tests are failing since r237646 - "Resync XHR Web Platform Tests from upstream 44dd29fb0d"

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Miguel Gomez]

These are the failing tests and the diffs:

imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/xhr/getallresponseheaders-actual.txt
@@ -4,6 +4,6 @@
 PASS XMLHttpRequest: getAllResponseHeaders() 2 
 PASS XMLHttpRequest: getAllResponseHeaders() 3 
 PASS XMLHttpRequest: getAllResponseHeaders() 4 
-FAIL XMLHttpRequest: getAllResponseHeaders() 5 assert_equals: expected "heya: , \v\f, 1, , , 2\r\n" but got "heya: , , 1, , , 2\r\n"
+PASS XMLHttpRequest: getAllResponseHeaders() 5 
 PASS XMLHttpRequest: getAllResponseHeaders() 6 
 

imported/w3c/web-platform-tests/xhr/getresponseheader.any.html [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/xhr/getresponseheader.any-actual.txt
@@ -3,6 +3,6 @@
 PASS getResponseHeader('content-length') expects 0, 0 
 PASS getResponseHeader('double-trouble') expects ,  
 PASS getResponseHeader('foo-test') expects 1, 2, 3 
-FAIL getResponseHeader('heya') expects , , 1, , , 2 assert_equals: expected ", \v\f, 1, , , 2" but got ", , 1, , , 2"
+PASS getResponseHeader('heya') expects , , 1, , , 2 
 PASS getResponseHeader('www-authenticate') expects 1, 2, 3, 4 
 

imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker.html [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-actual.txt
@@ -3,6 +3,6 @@
 PASS getResponseHeader('content-length') expects 0, 0 
 PASS getResponseHeader('double-trouble') expects ,  
 PASS getResponseHeader('foo-test') expects 1, 2, 3 
-FAIL getResponseHeader('heya') expects , , 1, , , 2 assert_equals: expected ", \v\f, 1, , , 2" but got ", , 1, , , 2"
+PASS getResponseHeader('heya') expects , , 1, , , 2 
 PASS getResponseHeader('www-authenticate') expects 1, 2, 3, 4 
 

imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm [ Failure ]
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/xhr/setrequestheader-content-type-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/xhr/setrequestheader-content-type-actual.txt
@@ -2,37 +2,37 @@
 CONSOLE MESSAGE: line 22: ArrayBuffer is deprecated in XMLHttpRequest.send(). Use ArrayBufferView instead.
 CONSOLE MESSAGE: line 22: ArrayBuffer is deprecated in XMLHttpRequest.send(). Use ArrayBufferView instead.
 
-FAIL setRequestHeader("") sends a blank string assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
-FAIL setRequestHeader(" ") sends the string " " assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS setRequestHeader("") sends a blank string 
+PASS setRequestHeader(" ") sends the string " " 
 PASS setRequestHeader(null) sends the string "null" 
 PASS setRequestHeader(undefined) sends the string "undefined" 
 PASS String request has correct default Content-Type of "text/plain;charset=UTF-8" 
 PASS String request keeps setRequestHeader() Content-Type, with charset adjusted to UTF-8 
-FAIL XML Document request respects setRequestHeader("") assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS XML Document request respects setRequestHeader("") 
 PASS XML Document request has correct default Content-Type of "application/xml;charset=UTF-8" 
 PASS XML Document request keeps setRequestHeader() Content-Type, with charset adjusted to UTF-8 
-FAIL HTML Document request respects setRequestHeader("") assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS HTML Document request respects setRequestHeader("") 
 PASS HTML Document request has correct default Content-Type of "text/html;charset=UTF-8" 
 PASS HTML Document request keeps setRequestHeader() Content-Type, with charset adjusted to UTF-8 
-FAIL Blob request respects setRequestHeader("") to be specified assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
-FAIL Blob request with unset type sends no Content-Type without setRequestHeader() call assert_equals: expected "" but got "Content-Type:  \n"
+PASS Blob request respects setRequestHeader("") to be specified 
+FAIL Blob request with unset type sends no Content-Type without setRequestHeader() call assert_equals: expected "" but got "Content-Type: \n"
 PASS Blob request with unset type keeps setRequestHeader() Content-Type and charset 
-FAIL Blob request with set type respects setRequestHeader("") to be specified assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS Blob request with set type respects setRequestHeader("") to be specified 
 PASS Blob request with set type uses that it for Content-Type unless setRequestHeader() 
 PASS Blob request with set type keeps setRequestHeader() Content-Type and charset 
-FAIL ArrayBuffer request respects setRequestHeader("") assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS ArrayBuffer request respects setRequestHeader("") 
 PASS ArrayBuffer request sends no Content-Type without setRequestHeader() call 
 PASS ArrayBuffer request keeps setRequestHeader() Content-Type and charset 
-FAIL ArrayBufferView request respects setRequestHeader("") assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS ArrayBufferView request respects setRequestHeader("") 
 PASS ArrayBufferView request sends no Content-Type without setRequestHeader() call 
 PASS ArrayBufferView request keeps setRequestHeader() Content-Type and charset 
-FAIL FormData request respects setRequestHeader("") assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS FormData request respects setRequestHeader("") 
 PASS FormData request has correct default Content-Type of "multipart/form-data; boundary=_" 
 PASS FormData request keeps setRequestHeader() Content-Type and charset 
-FAIL URLSearchParams respects setRequestHeader("") assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS URLSearchParams respects setRequestHeader("") 
 FAIL URLSearchParams request has correct default Content-Type of "application/x-www-form-urlencoded;charset=UTF-8" assert_equals: expected "Content-Type: application/x-www-form-urlencoded;charset=UTF-8\n" but got "Content-Type: text/plain;charset=UTF-8\n"
 PASS URLSearchParams request keeps setRequestHeader() Content-Type, with charset adjusted to UTF-8 
-FAIL ReadableStream request respects setRequestHeader("") assert_equals: expected "Content-Type: \n" but got "Content-Type:  \n"
+PASS ReadableStream request respects setRequestHeader("") 
 FAIL ReadableStream request with under type sends no Content-Type without setRequestHeader() call assert_equals: expected "" but got "Content-Type: text/plain;charset=UTF-8\n"
 FAIL ReadableStream request keeps setRequestHeader() Content-Type and charset assert_equals: expected "Content-Type: application/xml;charset=ASCII\n" but got "Content-Type: application/xml;charset=UTF-8\n"

[Pablo Saavedra]

Fixed during regular gardening in https://bugs.webkit.org/show_bug.cgi?id=206062