Bug 192136 – A sender created through addTransceiver and populated using addTrack should have its source set

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

A sender create through addTransceiver and populated using addTrack should have its source set

[youenn fablet]

Created attachment 355978 [details]
Patch

[Eric Carlson]

Comment on attachment 355978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355978&action=review

> Source/WebCore/ChangeLog:3
> +        A sender create through addTransceiver and populated using addTrack should have its source set

Nit: s/create/created/

[youenn fablet]

Created attachment 356025 [details]
Patch for landing

[youenn fablet]

(In reply to Eric Carlson from comment #2)
> Comment on attachment 355978 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=355978&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        A sender create through addTransceiver and populated using addTrack should have its source set
> 
> Nit: s/create/created/

Fixed

[WebKit Commit Bot]

Comment on attachment 356025 [details]
Patch for landing

Clearing flags on attachment: 356025

Committed r238680: <https://trac.webkit.org/changeset/238680>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46349472>

[Ryan Haddad]

(In reply to WebKit Commit Bot from comment #5)
> Committed r238680: <https://trac.webkit.org/changeset/238680>

This change has caused layout tests imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https.html and webrtc/remove-track.html to consistently fail an assertion on macOS and iOS WK2:

ASSERTION FAILED: !hasSource()
/Volumes/Data/slave/sierra-debug/build/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h(92) : void WebCore::LibWebRTCRtpSenderBackend::setSource(Source &&)
1   0x11b22c709 WTFCrash
2   0x10a0df85b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x10a2854d4 WebCore::LibWebRTCRtpSenderBackend::setSource(WTF::Variant<std::nullptr_t, WTF::Ref<WebCore::RealtimeOutgoingAudioSource, WTF::DumbPtrTraits<WebCore::RealtimeOutgoingAudioSource> >, WTF::Ref<WebCore::RealtimeOutgoingVideoSource, WTF::DumbPtrTraits<WebCore::RealtimeOutgoingVideoSource> > >&&)
4   0x10a2b6e40 WebCore::LibWebRTCRtpSenderBackend::takeSource(WebCore::LibWebRTCRtpSenderBackend&)
5   0x10a2b4efc WebCore::LibWebRTCPeerConnectionBackend::addTrack(WebCore::MediaStreamTrack&, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul>&&)
6   0x10b9e9b91 WebCore::RTCPeerConnection::addTrack(WTF::Ref<WebCore::MediaStreamTrack, WTF::DumbPtrTraits<WebCore::MediaStreamTrack> >&&, WTF::Vector<std::__1::reference_wrapper<WebCore::MediaStream>, 0ul, WTF::CrashOnOverflow, 16ul> const&)
7   0x10afadc0b WebCore::jsRTCPeerConnectionPrototypeFunctionAddTrackBody(JSC::ExecState*, WebCore::JSRTCPeerConnection*, JSC::ThrowScope&)
8   0x10afa04d0 long long WebCore::IDLOperation<WebCore::JSRTCPeerConnection>::call<&(WebCore::jsRTCPeerConnectionPrototypeFunctionAddTrackBody(JSC::ExecState*, WebCore::JSRTCPeerConnection*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState&, char const*)
9   0x10afa01bc WebCore::jsRTCPeerConnectionPrototypeFunctionAddTrack(JSC::ExecState*)
10  0x7f82b2ac177
11  0x11b6e95b4 llint_entry

[Ryan Haddad]

Reverted r238680 for reason:

Caused existing webrtc layout tests to fail an assertion.

Committed r238720: <https://trac.webkit.org/changeset/238720>

[youenn fablet]

Created attachment 356463 [details]
Patch

[youenn fablet]

(In reply to youenn fablet from comment #10)
> Created attachment 356463 [details]
> Patch

Debug ASSERT was not correct when removing and readding a track.
I now explicitly clear the source to keep the assert.

[WebKit Commit Bot]

Comment on attachment 356463 [details]
Patch

Clearing flags on attachment: 356463

Committed r238845: <https://trac.webkit.org/changeset/238845>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.