Bug 192132 - CSS subresource loads should not be observable from resource timing if the stylesheet is opaque
Summary: CSS subresource loads should not be observable from resource timing if the st...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-28 19:27 PST by youenn fablet
Modified: 2018-11-29 15:07 PST (History)
6 users (show)

See Also:

Attachments
Patch (29.24 KB, patch)
2018-11-28 19:32 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (29.26 KB, patch)
2018-11-28 20:03 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (29.26 KB, patch)
2018-11-28 20:54 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (38.61 KB, patch)
2018-11-29 09:48 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (38.99 KB, patch)
2018-11-29 13:34 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-11-28 19:27:13 PST 
CSS subresource loads should not be observable from resource timing if the stylesheet is opaque.
Comment 1 youenn fablet 2018-11-28 19:32:10 PST 
Created attachment 355962 [details]
Patch
Comment 2 youenn fablet 2018-11-28 20:03:58 PST 
Created attachment 355969 [details]
Patch
Comment 3 youenn fablet 2018-11-28 20:54:21 PST 
Created attachment 355973 [details]
Patch
Comment 4 youenn fablet 2018-11-29 09:48:53 PST 
Created attachment 356014 [details]
Patch
Comment 5 Ryosuke Niwa 2018-11-29 12:43:30 PST 
Comment on attachment 356014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356014&action=review

> LayoutTests/http/tests/security/resources/loading-subresources.css:5
> +}

Maybe add a test for cursor image too?
Comment 6 Simon Fraser (smfr) 2018-11-29 12:58:54 PST 
Masks can reference remote images, but maybe that's taken care of by the CSSImageValue changes. Filters and clip-path can use URI references (we don't support those in external files yet, but should).
Comment 7 youenn fablet 2018-11-29 13:34:15 PST 
Created attachment 356047 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-11-29 15:06:51 PST 
Comment on attachment 356047 [details]
Patch for landing

Clearing flags on attachment: 356047

Committed r238698: <https://trac.webkit.org/changeset/238698>
Comment 9 WebKit Commit Bot 2018-11-29 15:06:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-11-29 15:07:44 PST 
<rdar://problem/46355868>