Bug 192128 - Make generic ScrollAnimator
Summary: Make generic ScrollAnimator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-28 18:18 PST by Don Olmstead
Modified: 2018-11-29 10:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (23.38 KB, patch)
2018-11-28 18:21 PST, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (24.47 KB, patch)
2018-11-29 09:26 PST, Don Olmstead
mcatanzaro: review+
Details | Formatted Diff | Diff
Patch (24.48 KB, patch)
2018-11-29 10:03 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-11-28 18:18:27 PST
The contents of platform/gtk/ScrollAnimatorGtk doesn't contain anything thats GTK specific. Use that as a shared generic implementation.
Comment 1 Don Olmstead 2018-11-28 18:21:19 PST
Created attachment 355956 [details]
Patch
Comment 2 Don Olmstead 2018-11-28 18:31:44 PST
I think EWS is having a problem because of unified sources....
Comment 3 Frédéric Wang (:fredw) 2018-11-29 05:38:49 PST
Comment on attachment 355956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review

> Source/WebCore/ChangeLog:15
> +        compile at this time.

ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59

Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-)
Comment 4 Frédéric Wang (:fredw) 2018-11-29 05:50:20 PST
Comment on attachment 355956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review

>> Source/WebCore/ChangeLog:15
>> +        compile at this time.
> 
> ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59
> 
> Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-)

OK, I stand corrected, what I need is ScrollAnimationSmooth!
Comment 5 Michael Catanzaro 2018-11-29 08:21:14 PST
Comment on attachment 355956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review

>>> Source/WebCore/ChangeLog:15
>>> +        compile at this time.
>> 
>> ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59
>> 
>> Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-)
> 
> OK, I stand corrected, what I need is ScrollAnimationSmooth!

What is it you really need? (Not ScrollAnimatorSmooth.)
Comment 6 Frédéric Wang (:fredw) 2018-11-29 08:26:51 PST
(In reply to Michael Catanzaro from comment #5)
> What is it you really need? (Not ScrollAnimatorSmooth.)

I'm using ScrollAnimaTIONSmooth to implement programmatic smooth scrolling. Don is removing ScrollAnimaTORSmooth.
Comment 7 Don Olmstead 2018-11-29 09:26:29 PST
Created attachment 356013 [details]
Patch

Including potential build fix due to unified sources.
Comment 8 Don Olmstead 2018-11-29 09:40:34 PST
Comment on attachment 356013 [details]
Patch

Ok GTK is happy now. Ready for a review.
Comment 9 Michael Catanzaro 2018-11-29 09:56:05 PST
Comment on attachment 356013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356013&action=review

> Source/WebCore/ChangeLog:8
> +       No new tests. No change in behavior.

This line is one space too far to the left!
Comment 10 Don Olmstead 2018-11-29 10:03:50 PST
Created attachment 356015 [details]
Patch
Comment 11 WebKit Commit Bot 2018-11-29 10:36:38 PST
Comment on attachment 356015 [details]
Patch

Clearing flags on attachment: 356015

Committed r238675: <https://trac.webkit.org/changeset/238675>
Comment 12 WebKit Commit Bot 2018-11-29 10:36:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2018-11-29 10:37:21 PST
<rdar://problem/46346604>