Bug 192126 - [macOS] Add logging for some sandbox entries.
Summary: [macOS] Add logging for some sandbox entries.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-28 17:21 PST by Per Arne Vollan
Modified: 2018-11-30 09:42 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.02 KB, patch)
2018-11-28 17:31 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (1.21 MB, application/zip)
2018-11-28 18:17 PST, EWS Watchlist 		no flags Details
Patch (6.81 KB, patch)
2018-11-29 10:05 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (1.48 MB, application/zip)
2018-11-29 10:36 PST, EWS Watchlist 		no flags Details
Patch (6.90 KB, patch)
2018-11-29 11:52 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (6.84 KB, patch)
2018-11-29 12:40 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-11-28 17:21:20 PST 
Add logging for sandbox entries which are possibly not needed.
Comment 1 Radar WebKit Bug Importer 2018-11-28 17:22:03 PST 
<rdar://problem/46327777>
Comment 2 Per Arne Vollan 2018-11-28 17:31:07 PST 
Created attachment 355949 [details]
Patch
Comment 3 EWS Watchlist 2018-11-28 18:17:00 PST 
Comment on attachment 355949 [details]
Patch

Attachment 355949 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10190227

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-11-28 18:17:01 PST 
Created attachment 355955 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Brent Fulgham 2018-11-28 19:34:35 PST 
Comment on attachment 355949 [details]
Patch

Looks correct.
Comment 6 Brent Fulgham 2018-11-28 19:37:26 PST 
Comment on attachment 355949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355949&action=review

Switching to r- to fix the multiple crashes.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:608
> +(allow mach-lookup (with report)

Is the “(with report)” unavailable on older OS? You might need to make this section conditional by OS.
Comment 7 Per Arne Vollan 2018-11-29 10:05:17 PST 
Created attachment 356016 [details]
Patch
Comment 8 EWS Watchlist 2018-11-29 10:36:16 PST 
Comment on attachment 356016 [details]
Patch

Attachment 356016 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10199148

Number of test failures exceeded the failure limit.
Comment 9 EWS Watchlist 2018-11-29 10:36:17 PST 
Created attachment 356022 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 10 Per Arne Vollan 2018-11-29 11:52:45 PST 
Created attachment 356030 [details]
Patch
Comment 11 Per Arne Vollan 2018-11-29 12:40:59 PST 
Created attachment 356037 [details]
Patch
Comment 12 Brent Fulgham 2018-11-29 14:14:28 PST 
Comment on attachment 356037 [details]
Patch

Great! R=me
Comment 13 Per Arne Vollan 2018-11-29 14:16:55 PST 
(In reply to Brent Fulgham from comment #12)
> Comment on attachment 356037 [details]
> Patch
> 
> Great! R=me

Thanks for reviewing :)
Comment 14 WebKit Commit Bot 2018-11-29 15:28:50 PST 
Comment on attachment 356037 [details]
Patch

Clearing flags on attachment: 356037

Committed r238703: <https://trac.webkit.org/changeset/238703>
Comment 15 WebKit Commit Bot 2018-11-29 15:28:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 16 Per Arne Vollan 2018-11-30 09:42:55 PST 
Landed followup fix in <https://trac.webkit.org/changeset/238740/webkit>.