RESOLVED FIXED 192110
ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
https://bugs.webkit.org/show_bug.cgi?id=192110
Summary ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
Mark Lam
Reported 2018-11-28 15:16:38 PST
Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h because it is also needed in WebCore for the CSS JIT. Also contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore (and other projects) as well as JSC. Hence, there's no reason why ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h. <rdar://problem/46317746>
Attachments
proposed patch. (2.69 KB, patch)
2018-11-28 15:24 PST, Mark Lam
saam: review+
Mark Lam
Comment 1 2018-11-28 15:24:35 PST
Created attachment 355927 [details] proposed patch.
Mark Lam
Comment 2 2018-11-28 17:23:19 PST
Thanks for the review. Landed in r238650: <http://trac.webkit.org/r238650>.
Note You need to log in before you can comment on or make changes to this bug.