WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
192080
webkitbot gets an HTTP 302 error when using the 'hi' command
https://bugs.webkit.org/show_bug.cgi?id=192080
Summary
webkitbot gets an HTTP 302 error when using the 'hi' command
Lucas Forschler
Reported
2018-11-28 09:22:26 PST
webkitbot: hi returns an HTTP 302 error. In the code, I see that WKR also pukes when using this command, so it's likely we need to special case webkitbot the same way to do WKR.
Attachments
v1 patch for review.
(1.56 KB, patch)
2018-11-28 09:42 PST
,
Lucas Forschler
ap
: review+
lforschler
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Lucas Forschler
Comment 1
2018-11-28 09:42:51 PST
Created
attachment 355879
[details]
v1 patch for review.
Alexey Proskuryakov
Comment 2
2018-11-28 09:46:55 PST
Comment on
attachment 355879
[details]
v1 patch for review. View in context:
https://bugs.webkit.org/attachment.cgi?id=355879&action=review
> Tools/Scripts/webkitpy/tool/bot/irc_command.py:123 > quips = tool.bugs.quips()
A better approach would be to delete all code related to quips - it's not used at all at this point.
Lucas Forschler
Comment 3
2018-11-28 09:52:09 PST
Committed
r238618
: <
https://trac.webkit.org/changeset/238618
>
Radar WebKit Bug Importer
Comment 4
2018-11-28 09:53:36 PST
<
rdar://problem/46312665
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug