Bug 192080 - webkitbot gets an HTTP 302 error when using the 'hi' command
Summary: webkitbot gets an HTTP 302 error when using the 'hi' command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 11
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-28 09:22 PST by Lucas Forschler
Modified: 2018-11-28 09:53 PST (History)
4 users (show)

See Also:


Attachments
v1 patch for review. (1.56 KB, patch)
2018-11-28 09:42 PST, Lucas Forschler
ap: review+
lforschler: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2018-11-28 09:22:26 PST
webkitbot: hi
returns an HTTP 302 error.
In the code, I see that WKR also pukes when using this command, so it's likely we need to special case webkitbot the same way to do WKR.
Comment 1 Lucas Forschler 2018-11-28 09:42:51 PST
Created attachment 355879 [details]
v1 patch for review.
Comment 2 Alexey Proskuryakov 2018-11-28 09:46:55 PST
Comment on attachment 355879 [details]
v1 patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=355879&action=review

> Tools/Scripts/webkitpy/tool/bot/irc_command.py:123
>          quips = tool.bugs.quips()

A better approach would be to delete all code related to quips - it's not used at all at this point.
Comment 3 Lucas Forschler 2018-11-28 09:52:09 PST
Committed r238618: <https://trac.webkit.org/changeset/238618>
Comment 4 Radar WebKit Bug Importer 2018-11-28 09:53:36 PST
<rdar://problem/46312665>