Bug 192054 - Modernize version checks for same site cookie support
Summary: Modernize version checks for same site cookie support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 16:38 PST by Alexey Proskuryakov
Modified: 2018-11-28 09:21 PST (History)
10 users (show)

See Also:

Attachments
proposed patch (4.34 KB, patch)
2018-11-27 16:39 PST, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-11-27 16:38:20 PST 
More bikeshedding.
Comment 1 Alexey Proskuryakov 2018-11-27 16:39:45 PST 
Created attachment 355816 [details]
proposed patch
Comment 2 Tim Horton 2018-11-27 18:30:37 PST 
Comment on attachment 355816 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355816&action=review

This one seems reasonable.

> Source/WTF/wtf/Platform.h:1384
> +/* FIXME: Should this be enabled or IOS_FAMILY, not just IOS? */

Surely, no?
Comment 3 Alexey Proskuryakov 2018-11-28 09:20:29 PST 
Committed http://trac.webkit.org/r238614

> Surely, no?

Seems almost certain, but I didn't feel like making a behavior change here.
Comment 4 Radar WebKit Bug Importer 2018-11-28 09:21:32 PST 
<rdar://problem/46311672>