Bug 192049 - Move logCookieInformation bool from NetworkProcess to NetworkSession
Summary: Move logCookieInformation bool from NetworkProcess to NetworkSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 16:06 PST by Alex Christensen
Modified: 2018-11-28 13:10 PST (History)
2 users (show)

See Also:


Attachments
Patch (21.57 KB, patch)
2018-11-27 16:07 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (21.66 KB, patch)
2018-11-27 20:24 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (21.66 KB, patch)
2018-11-27 21:55 PST, Alex Christensen
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-11-27 16:06:34 PST
Move logCookieInformation bool from NetworkProcess to NetworkSession
Comment 1 Alex Christensen 2018-11-27 16:07:07 PST
Created attachment 355805 [details]
Patch
Comment 2 Chris Dumez 2018-11-27 16:41:25 PST
Comment on attachment 355805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355805&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:460
> +        if (session->logCookieInformation())

This is a bad name, makes it sound like it is actually logging stuff. Should be named shouldLogCookieInformation() like it was.

> Source/WebKit/NetworkProcess/NetworkSession.h:50
> +    virtual bool logCookieInformation() const { return false; }

Bad naming.

> Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:58
> +    bool logCookieInformation { false };

Bad naming.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:86
> +    bool m_logCookieInformation { false };

Bad naming.
Comment 3 Alex Christensen 2018-11-27 20:24:10 PST
Created attachment 355844 [details]
Patch
Comment 4 Alex Christensen 2018-11-27 21:55:17 PST
Created attachment 355847 [details]
Patch
Comment 5 Alex Christensen 2018-11-28 13:09:22 PST
http://trac.webkit.org/r238630
Comment 6 Radar WebKit Bug Importer 2018-11-28 13:10:40 PST
<rdar://problem/46319225>