RESOLVED FIXED 192046
Remove another OS version check from NetworkDataTaskCocoa.mm 
https://bugs.webkit.org/show_bug.cgi?id=192046
Summary Remove another OS version check from NetworkDataTaskCocoa.mm
Alexey Proskuryakov
Reported 2018-11-27 15:45:27 PST
More bikeshedding.
Attachments
proposed patch (2.81 KB, patch)
2018-11-27 15:47 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (2.79 KB, patch)
2018-11-27 16:21 PST, Alexey Proskuryakov 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-11-27 15:47:22 PST
Created attachment 355799 [details] proposed patch
Alexey Proskuryakov
Comment 2 2018-11-27 15:47:58 PST
This also fixes the check, which should have been about SDK version, not target OS version.
Tim Horton
Comment 3 2018-11-27 16:03:56 PST
Comment on attachment 355799 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355799&action=review > Source/WTF/wtf/Platform.h:1385 > +#define HAVE_INACCURATE_NULLABILITY_SPECIFIER_ON_NSHTTPCOOKIESTORAGE__INITWITHIDENTIFIER 1 Should we do the same thing? HAVE(NSHTTPCOOKIESTORAGE_INITWITHIDENTIFIER_WITH_INACCURATE_NULLABILITY_SPECIFIER)?
Tim Horton
Comment 4 2018-11-27 16:04:21 PST
Comment on attachment 355799 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355799&action=review >> Source/WTF/wtf/Platform.h:1385 >> +#define HAVE_INACCURATE_NULLABILITY_SPECIFIER_ON_NSHTTPCOOKIESTORAGE__INITWITHIDENTIFIER 1 > > Should we do the same thing? HAVE(NSHTTPCOOKIESTORAGE_INITWITHIDENTIFIER_WITH_INACCURATE_NULLABILITY_SPECIFIER)? I ALSO THINK YOU CAN PROBABLY LEAVE OUT THE WORD SPECIFIER
Tim Horton
Comment 5 2018-11-27 16:04:37 PST
(because the nullability... is inaccurate)
Alexey Proskuryakov
Comment 6 2018-11-27 16:21:00 PST
Created attachment 355807 [details] proposed patch Sure thing, changed as you suggested (but keeping the double underscore)
Alex Christensen
Comment 7 2018-11-27 20:13:16 PST
Comment on attachment 355807 [details] proposed patch I'm not sure how this helps anything, but r=me
Alexey Proskuryakov
Comment 8 2018-11-28 09:28:31 PST
Committed http://trac.webkit.org/r238615
Radar WebKit Bug Importer
Comment 9 2018-11-28 09:30:01 PST
<rdar://problem/46311922>
Note You need to log in before you can comment on or make changes to this bug.