Bug 192041 - Modernize the check for kCFURLRequestContentDecoderSkipURLCheck existence
Summary: Modernize the check for kCFURLRequestContentDecoderSkipURLCheck existence
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 14:57 PST by Alexey Proskuryakov
Modified: 2018-11-29 12:54 PST (History)
11 users (show)

See Also:


Attachments
proposed patch (7.70 KB, patch)
2018-11-27 14:59 PST, Alexey Proskuryakov
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-11-27 14:57:44 PST
More bikeshedding. But also some big FIXMEs here.
Comment 1 Alexey Proskuryakov 2018-11-27 14:59:59 PST
Created attachment 355788 [details]
proposed patch
Comment 2 EWS Watchlist 2018-11-27 15:01:59 PST
Attachment 355788 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/mac/ResourceHandleMac.mm:116:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2018-11-29 12:41:13 PST
Comment on attachment 355788 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355788&action=review

> Source/WTF/wtf/Platform.h:1386
> +/* The override isn't needed on iOS family, as the default behavior is to no sniff. */

s/no/not/, I think?
Comment 4 Alexey Proskuryakov 2018-11-29 12:53:07 PST
Committed http://trac.webkit.org/r238685
Comment 5 Radar WebKit Bug Importer 2018-11-29 12:54:37 PST
<rdar://problem/46351213>