Bug 192040 - Refactor duplicate code for calling into media controls
Summary: Refactor duplicate code for calling into media controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 14:50 PST by Eric Carlson
Modified: 2018-11-27 15:45 PST (History)
2 users (show)

See Also:

Attachments
Patch (23.38 KB, patch)
2018-11-27 15:05 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-11-27 14:50:29 PST 
All of the methods on HTMLMediaElement that call into JS have the same setup code.
Comment 1 Eric Carlson 2018-11-27 14:50:35 PST 
<rdar://problem/46278931>
Comment 2 Eric Carlson 2018-11-27 15:05:10 PST 
Created attachment 355789 [details]
Patch
Comment 3 WebKit Commit Bot 2018-11-27 15:45:52 PST 
Comment on attachment 355789 [details]
Patch

Clearing flags on attachment: 355789

Committed r238582: <https://trac.webkit.org/changeset/238582>
Comment 4 WebKit Commit Bot 2018-11-27 15:45:54 PST 
All reviewed patches have been landed.  Closing bug.