Bug 192032 - Make generic EventHandler methods
Summary: Make generic EventHandler methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 13:34 PST by Stephan Szabo
Modified: 2018-11-28 10:25 PST (History)
8 users (show)

See Also:


Attachments
Move EventHandler methods from EventHandlerGlib (10.81 KB, patch)
2018-11-27 14:14 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff
Move EventHandler methods from EventHandlerGlib (10.98 KB, patch)
2018-11-27 16:13 PST, Stephan Szabo
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.49 MB, application/zip)
2018-11-27 19:38 PST, EWS Watchlist
no flags Details
Move EventHandler methods from EventHandlerGlib (10.98 KB, patch)
2018-11-28 07:26 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-11-27 13:34:20 PST
Currently there are a number of methods in EventHandlerGlib that can be used for other non-apple platforms.

Of those, there are two methods which seem like generic implementations, but currently have different behavior for Windows, so those are overridden there.
Comment 1 Stephan Szabo 2018-11-27 14:14:54 PST
Created attachment 355778 [details]
Move EventHandler methods from EventHandlerGlib
Comment 2 Don Olmstead 2018-11-27 16:00:30 PST
Comment on attachment 355778 [details]
Move EventHandler methods from EventHandlerGlib

View in context: https://bugs.webkit.org/attachment.cgi?id=355778&action=review

Overall LGTM.

What's up with EventHandler::shouldSwapScrollDirection though in the EventHandlerGlib.cpp code? Should that just be a !PLATFORM(GTK)in EventHandler.cpp since WPE doesn't actually implement. Then it would be EventHandlerGtk.cpp.

> Source/WebCore/page/EventHandler.cpp:4279
> +#if !PLATFORM(MAC) && !PLATFORM(IOS)

This could be simplified to !PLATFORM(COCOA)

> Source/WebCore/page/EventHandler.cpp:4338
> +#if !PLATFORM(MAC) && !PLATFORM(IOS) && !PLATFORM(WIN)

Same
Comment 3 Stephan Szabo 2018-11-27 16:09:51 PST
> What's up with EventHandler::shouldSwapScrollDirection though in the EventHandlerGlib.cpp code?

I'm not sure. It seems like the implementation in EventHandler.cpp was there when EventHandlerGtk and EventHandlerWPE merged into EventHandlerGlib, so I left it as is.
Comment 4 Stephan Szabo 2018-11-27 16:13:39 PST
Created attachment 355806 [details]
Move EventHandler methods from EventHandlerGlib
Comment 5 EWS Watchlist 2018-11-27 19:38:30 PST
Comment on attachment 355806 [details]
Move EventHandler methods from EventHandlerGlib

Attachment 355806 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10176073

New failing tests:
media/no-fullscreen-when-hidden.html
Comment 6 EWS Watchlist 2018-11-27 19:38:32 PST
Created attachment 355841 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 7 Stephan Szabo 2018-11-28 07:26:31 PST
Created attachment 355871 [details]
Move EventHandler methods from EventHandlerGlib
Comment 8 WebKit Commit Bot 2018-11-28 10:24:13 PST
Comment on attachment 355871 [details]
Move EventHandler methods from EventHandlerGlib

Clearing flags on attachment: 355871

Committed r238622: <https://trac.webkit.org/changeset/238622>
Comment 9 WebKit Commit Bot 2018-11-28 10:24:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-11-28 10:25:46 PST
<rdar://problem/46313705>