Bug 192031 - Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files
Summary: Update generate-{derived,unified}-sources scripts to support generating .xcfi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 13:27 PST by Keith Rollin
Modified: 2018-11-28 14:10 PST (History)
10 users (show)

See Also:


Attachments
Patch (16.73 KB, patch)
2018-11-27 13:31 PST, Keith Rollin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.70 MB, application/zip)
2018-11-27 16:41 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2018-11-27 13:27:58 PST
The Generate Derived Sources and Generate Unified Sources build phases in Xcode need to have their inputs and outputs specified. This specification will come in the form of .xcfilelist files that will be attached to these build phases. There is one .xcfilelist file that lists the input file and one that lists the output files. As part of this work, the various generate-{derived,unified}-sources scripts that are executed in these Generate build phases are modified to help in the creation of these .xcfilelist files. In particular, they can now be invoked with command-line parameters. These parameters are then used to alter the normal execution of these scripts, causing them to produce the .xcfilelist files as opposed to actually generating the files that are listed in those files.
Comment 1 Radar WebKit Bug Importer 2018-11-27 13:28:28 PST
<rdar://problem/46286816>
Comment 2 Keith Rollin 2018-11-27 13:31:32 PST
Created attachment 355771 [details]
Patch
Comment 3 EWS Watchlist 2018-11-27 16:41:48 PST
Comment on attachment 355771 [details]
Patch

Attachment 355771 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10173238

New failing tests:
media/no-fullscreen-when-hidden.html
Comment 4 EWS Watchlist 2018-11-27 16:41:50 PST
Created attachment 355817 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 WebKit Commit Bot 2018-11-28 14:10:00 PST
Comment on attachment 355771 [details]
Patch

Clearing flags on attachment: 355771

Committed r238639: <https://trac.webkit.org/changeset/238639>
Comment 6 WebKit Commit Bot 2018-11-28 14:10:02 PST
All reviewed patches have been landed.  Closing bug.