Bug 192029 - Update generate-unified-source-bundles.rb to generate .xcfilelist files
Summary: Update generate-unified-source-bundles.rb to generate .xcfilelist files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 13:09 PST by Keith Rollin
Modified: 2018-11-28 14:07 PST (History)
6 users (show)

See Also:

Attachments
Patch (8.08 KB, patch)
2018-11-27 13:11 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (8.07 KB, patch)
2018-11-27 15:26 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2018-11-27 13:09:01 PST 
Update generate-unified-source-bundles.rb to generate output for .xcfilelist files. These files are used to indicate the sets of input and output files to Run Script build phases in Xcode. By invoking generate-unified-source-bundles.rb with -generate-xcfilelists, the script generates these .xcfilelist files. These .xcfilelist files can then be used to specify the inputs and outputs of the Generate Unified Sources build phases.
Comment 1 Radar WebKit Bug Importer 2018-11-27 13:09:26 PST 
<rdar://problem/46285918>
Comment 2 Keith Rollin 2018-11-27 13:11:53 PST 
Created attachment 355770 [details]
Patch
Comment 3 Keith Rollin 2018-11-27 14:39:06 PST 
Looks like my change to to_s is causing problems:

/home/buildbot/ews/WebKit/WebKitBuild/Release/DerivedSources/ForwardingHeaders/wtf/Scripts/generate-unified-source-bundles.rb:174:in `to_s': Unreachable (RuntimeError)
	from /home/buildbot/ews/WebKit/WebKitBuild/Release/DerivedSources/ForwardingHeaders/wtf/Scripts/generate-unified-source-bundles.rb:353:in `join'
	from /home/buildbot/ews/WebKit/WebKitBuild/Release/DerivedSources/ForwardingHeaders/wtf/Scripts/generate-unified-source-bundles.rb:353:in `<main>'
Comment 4 Keith Rollin 2018-11-27 15:26:13 PST 
Created attachment 355796 [details]
Patch
Comment 5 WebKit Commit Bot 2018-11-28 14:07:52 PST 
Comment on attachment 355796 [details]
Patch

Clearing flags on attachment: 355796

Committed r238638: <https://trac.webkit.org/changeset/238638>
Comment 6 WebKit Commit Bot 2018-11-28 14:07:54 PST 
All reviewed patches have been landed.  Closing bug.