Bug 192027 - [WebRTC][GStreamer] Use a GUniquePtr to hold the GstAudioConverter in our OutgoingAudioSource
Summary: [WebRTC][GStreamer] Use a GUniquePtr to hold the GstAudioConverter in our Out...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 12:30 PST by Thibault Saunier
Modified: 2018-11-28 04:43 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.00 KB, patch)
2018-11-27 12:30 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch (6.02 KB, patch)
2018-11-27 12:36 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.49 MB, application/zip)
2018-11-27 14:54 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-11-27 12:30:13 PST
[WebRTC][GStreamer] Use a GUniquePtr to hold the GstAudioConverter in our OutgoingAudioSource
Comment 1 Thibault Saunier 2018-11-27 12:30:47 PST
Created attachment 355762 [details]
Patch
Comment 2 EWS Watchlist 2018-11-27 12:33:48 PST
Attachment 355762 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Thibault Saunier 2018-11-27 12:36:04 PST
Created attachment 355764 [details]
Patch
Comment 4 EWS Watchlist 2018-11-27 14:54:09 PST
Comment on attachment 355764 [details]
Patch

Attachment 355764 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10172132

New failing tests:
http/wpt/css/css-animations/start-animation-001.html
Comment 5 EWS Watchlist 2018-11-27 14:54:10 PST
Created attachment 355787 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 WebKit Commit Bot 2018-11-28 04:41:58 PST
Comment on attachment 355764 [details]
Patch

Clearing flags on attachment: 355764

Committed r238606: <https://trac.webkit.org/changeset/238606>
Comment 7 WebKit Commit Bot 2018-11-28 04:41:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-11-28 04:43:02 PST
<rdar://problem/46306727>