Bug 192026 – [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Thibault Saunier]

[WebRTC][GStreamer] Make sure to have the default microphone on the top of the list

[Thibault Saunier]

Created attachment 355759 [details]
Patch

[Philippe Normand]

Comment on attachment 355759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355759&action=review

Looks good, just a couple nits

> Source/WebCore/ChangeLog:8
> +        [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list

Remove this :)

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:33
> +static gint
> +sortDevices(gconstpointer a, gconstpointer b)
> +{

In one line please!

[Thibault Saunier]

Created attachment 355866 [details]
Patch for landing

[Thibault Saunier]

Created attachment 355867 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 355867 [details]
Patch for landing

Rejecting attachment 355867 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 355867, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355867&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192026&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 355867 from bug 192026.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355867
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 7 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
patching file Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
patching file Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h
patching file Tools/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Tools/ChangeLog.rej
patching file Tools/flatpak/org.webkit.CommonModules.yaml
patching file Tools/gstreamer/jhbuild.modules
patching file Tools/gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10181753

[Thibault Saunier]

Created attachment 355868 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 355868 [details]
Patch for landing

Rejecting attachment 355868 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 355868, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355868&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192026&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 355868 from bug 192026.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355868
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 7 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
patching file Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
patching file Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h
patching file Tools/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Tools/ChangeLog.rej
patching file Tools/flatpak/org.webkit.CommonModules.yaml
patching file Tools/gstreamer/jhbuild.modules
patching file Tools/gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10181801

[Thibault Saunier]

Created attachment 355869 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 355869 [details]
Patch for landing

Clearing flags on attachment: 355869

Committed r238609: <https://trac.webkit.org/changeset/238609>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46308940>