Bug 192026 - [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list
Summary: [WebRTC][GStreamer] Make sure to have the default microphone on the top of th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 12:17 PST by Thibault Saunier
Modified: 2018-11-28 06:57 PST (History)
4 users (show)

See Also:


Attachments
Patch (18.01 KB, patch)
2018-11-27 12:17 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch for landing (18.28 KB, patch)
2018-11-28 05:56 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch for landing (18.49 KB, patch)
2018-11-28 05:56 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch for landing (18.49 KB, patch)
2018-11-28 06:04 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch for landing (18.28 KB, patch)
2018-11-28 06:19 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-11-27 12:17:04 PST
[WebRTC][GStreamer] Make sure to have the default microphone on the top of the list
Comment 1 Thibault Saunier 2018-11-27 12:17:46 PST
Created attachment 355759 [details]
Patch
Comment 2 Philippe Normand 2018-11-28 04:14:35 PST
Comment on attachment 355759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355759&action=review

Looks good, just a couple nits

> Source/WebCore/ChangeLog:8
> +        [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list

Remove this :)

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:33
> +static gint
> +sortDevices(gconstpointer a, gconstpointer b)
> +{

In one line please!
Comment 3 Thibault Saunier 2018-11-28 05:56:13 PST
Created attachment 355866 [details]
Patch for landing
Comment 4 Thibault Saunier 2018-11-28 05:56:41 PST
Created attachment 355867 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-11-28 05:57:25 PST
Comment on attachment 355867 [details]
Patch for landing

Rejecting attachment 355867 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 355867, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355867&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192026&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 355867 from bug 192026.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355867
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 7 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
patching file Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
patching file Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h
patching file Tools/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Tools/ChangeLog.rej
patching file Tools/flatpak/org.webkit.CommonModules.yaml
patching file Tools/gstreamer/jhbuild.modules
patching file Tools/gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10181753
Comment 6 Thibault Saunier 2018-11-28 06:04:45 PST
Created attachment 355868 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-11-28 06:06:58 PST
Comment on attachment 355868 [details]
Patch for landing

Rejecting attachment 355868 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 355868, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355868&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192026&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 355868 from bug 192026.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355868
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 7 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
patching file Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
patching file Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h
patching file Tools/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Tools/ChangeLog.rej
patching file Tools/flatpak/org.webkit.CommonModules.yaml
patching file Tools/gstreamer/jhbuild.modules
patching file Tools/gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10181801
Comment 8 Thibault Saunier 2018-11-28 06:19:18 PST
Created attachment 355869 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2018-11-28 06:56:18 PST
Comment on attachment 355869 [details]
Patch for landing

Clearing flags on attachment: 355869

Committed r238609: <https://trac.webkit.org/changeset/238609>
Comment 10 WebKit Commit Bot 2018-11-28 06:56:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-11-28 06:57:57 PST
<rdar://problem/46308940>