192022 – Safe browsing warning details need to be visible on High Sierra

Bug 192022 - Safe browsing warning details need to be visible on High Sierra

Summary: Safe browsing warning details need to be visible on High Sierra

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alex Christensen

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-11-27 11:37 PST by Alex Christensen
Modified:	2018-11-28 14:12 PST (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (6.58 KB, patch) 2018-11-27 11:42 PST, Alex Christensen	thorton: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Christensen 2018-11-27 11:37:42 PST

Safe browsing warning details need to be visible on High Sierra

Comment 1 Alex Christensen 2018-11-27 11:42:26 PST

Created attachment 355753 [details]
Patch

Comment 2 Tim Horton 2018-11-27 13:22:56 PST

Comment on attachment 355753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355753&action=review

> Source/WebKit/ChangeLog:8
> +        Something about AppKit, autolayout, view insertion order, and NSTextView makes the text layout with initial size of {0, 0} on High Sierra.

The verb form is "lay out".

Also this is super vague.

And a weirdly pseudoscientific fix.

Comment 3 Alex Christensen 2018-11-27 16:15:20 PST

https://trac.webkit.org/changeset/238585/webkit

Comment 4 Radar WebKit Bug Importer 2018-11-27 16:16:39 PST

<rdar://problem/46293149>

Comment 5 Truitt Savell 2018-11-28 09:41:05 PST

It looks like the change in https://trac.webkit.org/changeset/238585/webkit#file4

has caused an API failure on iOS


Failed

    TestWebKitAPI.SafeBrowsing.VisitUnsafeWebsite
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:215
        Expected: (warning.subviews.firstObject.subviews[2].frame.size.height) > (0), actual: 0 vs 0

Comment 6 Alex Christensen 2018-11-28 13:25:39 PST

Thanks, Truitt!  I'm looking into it.

Comment 7 Alex Christensen 2018-11-28 14:12:38 PST

http://trac.webkit.org/r238641