Bug 192019 - REGRESSION: stress/materialized-regexp-has-correct-last-index-set-by-match.js timing out on 32-bit JSC bot
Summary: REGRESSION: stress/materialized-regexp-has-correct-last-index-set-by-match.js...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Reported: 2018-11-27 11:11 PST by Ryan Haddad
Modified: 2018-12-17 23:59 PST (History)
6 users (show)

See Also:

proposed patch. (1.19 KB, patch)
2018-12-17 23:18 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-11-27 11:11:44 PST
stress/materialized-regexp-has-correct-last-index-set-by-match.js is timing out on the 32-bit JSC bot

Comment 1 Ryan Haddad 2018-11-27 11:12:38 PST
The first test run exhibiting this issue contained the following RegExp changes:

RegExp operations should not take fast patch if lastIndex is not numeric.

RegExpObject's collectMatches should not be using JSArray::push to fill in its match results.
Comment 2 Radar WebKit Bug Importer 2018-12-06 09:25:41 PST
Comment 3 Mark Lam 2018-12-17 23:18:55 PST
Created attachment 357541 [details]
proposed patch.
Comment 4 Yusuke Suzuki 2018-12-17 23:20:27 PST
Comment on attachment 357541 [details]
proposed patch.

Comment 5 WebKit Commit Bot 2018-12-17 23:59:07 PST
Comment on attachment 357541 [details]
proposed patch.

Clearing flags on attachment: 357541

Committed r239327: <https://trac.webkit.org/changeset/239327>
Comment 6 WebKit Commit Bot 2018-12-17 23:59:09 PST
All reviewed patches have been landed.  Closing bug.