Bug 192001 - Factor mask layer applying in RemoteLayerTreePropertyApplier into a shared function
Summary: Factor mask layer applying in RemoteLayerTreePropertyApplier into a shared fu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 02:11 PST by Antti Koivisto
Modified: 2018-11-27 05:36 PST (History)
6 users (show)

See Also:

Attachments
patch (5.55 KB, patch)
2018-11-27 02:14 PST, Antti Koivisto 		thorton: review+
Details | Formatted Diff | Diff
for landing (5.70 KB, patch)
2018-11-27 04:54 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-11-27 02:11:16 PST 
No need for separate Mac and iOS paths.
Comment 1 Antti Koivisto 2018-11-27 02:14:13 PST 
Created attachment 355717 [details]
patch
Comment 2 Antti Koivisto 2018-11-27 04:54:52 PST 
Created attachment 355722 [details]
for landing
Comment 3 WebKit Commit Bot 2018-11-27 04:57:14 PST 
Comment on attachment 355722 [details]
for landing

Rejecting attachment 355722 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 355722, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355722&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192001&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 355722 from bug 192001.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355722
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 3 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h
Hunk #1 FAILED at 41.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h.rej
patching file Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
Hunk #1 FAILED at 258.
Hunk #2 FAILED at 317.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10165654
Comment 4 Antti Koivisto 2018-11-27 05:35:04 PST 
https://trac.webkit.org/changeset/238550/webkit
Comment 5 Radar WebKit Bug Importer 2018-11-27 05:36:42 PST 
<rdar://problem/46274039>