RESOLVED FIXED 192001
Factor mask layer applying in RemoteLayerTreePropertyApplier into a shared function 
https://bugs.webkit.org/show_bug.cgi?id=192001
Summary Factor mask layer applying in RemoteLayerTreePropertyApplier into a shared fu...
Antti Koivisto
Reported 2018-11-27 02:11:16 PST
No need for separate Mac and iOS paths.
Attachments
patch (5.55 KB, patch)
2018-11-27 02:14 PST, Antti Koivisto 		thorton: review+
DetailsFormatted DiffDiff
for landing (5.70 KB, patch)
2018-11-27 04:54 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-11-27 02:14:13 PST
Created attachment 355717 [details] patch
Antti Koivisto
Comment 2 2018-11-27 04:54:52 PST
Created attachment 355722 [details] for landing
WebKit Commit Bot
Comment 3 2018-11-27 04:57:14 PST
Comment on attachment 355722 [details] for landing Rejecting attachment 355722 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 355722, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=355722&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=192001&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 355722 from bug 192001. Fetching: https://bugs.webkit.org/attachment.cgi?id=355722 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h Hunk #1 FAILED at 41. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h.rej patching file Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm Hunk #1 FAILED at 258. Hunk #2 FAILED at 317. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/10165654
Antti Koivisto
Comment 4 2018-11-27 05:35:04 PST
https://trac.webkit.org/changeset/238550/webkit
Radar WebKit Bug Importer
Comment 5 2018-11-27 05:36:42 PST
<rdar://problem/46274039>
Note You need to log in before you can comment on or make changes to this bug.