Bug 191996 – WebKit.AddAndRemoveDataDetectors hits a debug assertion after r238515

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

From logging in decode(Decoder& decoder, NSArray<Class> *allowedClasses), it looks like what's happening is that the allowedClasses contains:

    @[ NSArray.class, DDScannerResult.class ]

...however, the decoded object is a type of __NSArrayM, which is not exactly equal to NSArray.class (instead, it's one of the concrete implementations of NSArray).

Example crash trace (from https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29/builds/1014/steps/run-api-tests/logs/stdio)

    TestWebKitAPI.WebKit.AddAndRemoveDataDetectors
        ASSERTION FAILED: [allowedClasses containsObject:[object class]]
        /Volumes/Data/slave/ios-simulator-12-debug/build/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h(57) : std::optional<RetainPtr<T> > IPC::decode(IPC::Decoder &, NSArray<Class> *) [T = NSArray]
        1   0x106fbd359 WTFCrash
        2   0x10ab7975b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x10af506d4 std::optional<WTF::RetainPtr<NSArray> > IPC::decode<NSArray>(IPC::Decoder&, NSArray<objc_class*>*)
        4   0x10af5038b WebKit::DataDetectionResult::decode(IPC::Decoder&)
        5   0x10bb8556c std::optional<WebKit::DataDetectionResult> IPC::ArgumentCoder<WebKit::DataDetectionResult>::decode<WebKit::DataDetectionResult, (void*)0>(IPC::Decoder&)
        6   0x10bb65f54 IPC::Decoder& IPC::Decoder::operator>><WebKit::DataDetectionResult, (void*)0>(std::optional<WebKit::DataDetectionResult>&)
        7   0x10bb65e59 Messages::WebPage::DetectDataInAllFrames::callReply(IPC::Decoder&, WTF::CompletionHandler<void (WebKit::DataDetectionResult&&)>&&)

[Wenson Hsieh]

Created attachment 355713 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 355713 [details]
Patch

Rejecting attachment 355713 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355713, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355713&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=191996&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 355713 from bug 191996.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355713
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 6de0a5f9bcacc234f9c83bb8294967b7e9cbebbd and refs/remotes/origin/master differ, using rebase:
:040000 040000 5eef4691356aae46f7034c7d6599789a6993bce1 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 6de0a5f9bcacc234f9c83bb8294967b7e9cbebbd and refs/remotes/origin/master differ, using rebase:
:040000 040000 5eef4691356aae46f7034c7d6599789a6993bce1 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/10163574

[Wenson Hsieh]

Created attachment 355731 [details]
Rebase on trunk

[WebKit Commit Bot]

Comment on attachment 355731 [details]
Rebase on trunk

Clearing flags on attachment: 355731

Committed r238553: <https://trac.webkit.org/changeset/238553>

[Radar WebKit Bug Importer]

<rdar://problem/46276314>