Bug 191989 - webkitpy: Race conditions in ServerProcess tests
Summary: webkitpy: Race conditions in ServerProcess tests
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-26 16:16 PST by Jonathan Bedard
Modified: 2018-11-26 17:13 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.91 KB, patch)
2018-11-26 16:19 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-11-26 16:16:20 PST
Our bots have encountered some strange race conditions with the ServerProcess tests.
Comment 1 Jonathan Bedard 2018-11-26 16:17:12 PST
<rdar://problem/45536844>
Comment 2 Jonathan Bedard 2018-11-26 16:19:25 PST
Created attachment 355691 [details]
Patch
Comment 3 Jonathan Bedard 2018-11-26 16:20:34 PST
(In reply to Jonathan Bedard from comment #2)
> Created attachment 355691 [details]
> Patch

This isn't meant as a permanent solution, but it's going to be some time before I'm able to dig into this problem, and this is making like more difficult for our bot watchers.
Comment 4 WebKit Commit Bot 2018-11-26 17:02:51 PST
Comment on attachment 355691 [details]
Patch

Clearing flags on attachment: 355691

Committed r238534: <https://trac.webkit.org/changeset/238534>
Comment 5 WebKit Commit Bot 2018-11-26 17:02:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-26 17:03:35 PST
<rdar://problem/46262113>
Comment 7 Jonathan Bedard 2018-11-26 17:13:31 PST
Keeping this bug open since the landed patch is a mitigation not a solution.