Bug 191987 – Modernize the check for async _saveCookies existence

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alexey Proskuryakov]

Try removing an explicit OS version check.

[Alexey Proskuryakov]

Created attachment 355688 [details]
proposed patch

[Alexey Proskuryakov]

Bikeshedding is welcome, I want to polish the naming.

[Tim Horton]

Comment on attachment 355688 [details]
proposed patch

The other obvious option is "FOUNDATION_WITH_..."

[Alexey Proskuryakov]

Created attachment 355740 [details]
With Tim's sugestion

Yes, I think that's a bit better.

[WebKit Commit Bot]

Comment on attachment 355740 [details]
With Tim's sugestion

Rejecting attachment 355740 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355740, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355740&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=191987&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Failed to run "['Tools/Scripts/update-webkit']" exit_code: 1

Updating OpenSource
From https://git.webkit.org/git/WebKit
   1966f6a0b8c..71aad01c2a9  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 238557 = d403ecb81ae0329ee6784d062687e12049f038b7
last_rev is higher!: 238557 >= 238542 at /Applications/Xcode.app/Contents/Developer/usr/libexec/git-core/git-svn line 2091.

Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2963.

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 1

Updating OpenSource
From https://git.webkit.org/git/WebKit
   1966f6a0b8c..71aad01c2a9  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 238557 = d403ecb81ae0329ee6784d062687e12049f038b7
last_rev is higher!: 238557 >= 238542 at /Applications/Xcode.app/Contents/Developer/usr/libexec/git-core/git-svn line 2091.

Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2963.

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 1
Updating OpenSource
From https://git.webkit.org/git/WebKit
   1966f6a0b8c..71aad01c2a9  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 238557 = d403ecb81ae0329ee6784d062687e12049f038b7
last_rev is higher!: 238557 >= 238542 at /Applications/Xcode.app/Contents/Developer/usr/libexec/git-core/git-svn line 2091.

Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2963.

Full output: https://webkit-queues.webkit.org/results/10169410

[WebKit Commit Bot]

Comment on attachment 355740 [details]
With Tim's sugestion

Clearing flags on attachment: 355740

Committed r238567: <https://trac.webkit.org/changeset/238567>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46285110>