Bug 191983 – Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Deal with potentially null navigation object in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame().

[Chris Dumez]

<rdar://problem/46246863>

[Chris Dumez]

Created attachment 355681 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 355681 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 355681 [details]
Patch

Rejecting attachment 355681 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355681, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355681&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=191983&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 355681 from bug 191983.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355681
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 87e1d68cb7b3425a1307a238bd2175eb470845f6 and refs/remotes/origin/master differ, using rebase:
:040000 040000 c4807d5526188890c4ce139e5634cfaef2966d3e bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 87e1d68cb7b3425a1307a238bd2175eb470845f6 and refs/remotes/origin/master differ, using rebase:
:040000 040000 c4807d5526188890c4ce139e5634cfaef2966d3e bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/10162779

[Chris Dumez]

I manage to write a test, I'll update the patch.

[Chris Dumez]

Created attachment 355748 [details]
Patch

[Geoffrey Garen]

Comment on attachment 355748 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 355748 [details]
Patch

Clearing flags on attachment: 355748

Committed r238565: <https://trac.webkit.org/changeset/238565>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.