RESOLVED FIXED191981
Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing 
https://bugs.webkit.org/show_bug.cgi?id=191981
Summary Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to us...
Alex Christensen
Reported 2018-11-26 14:56:46 PST
Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing
Attachments
Patch (7.24 KB, patch)
2018-11-26 14:57 PST, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-11-26 14:57:44 PST
Created attachment 355680 [details] Patch
Tim Horton
Comment 2 2018-11-26 14:59:02 PST
Comment on attachment 355680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355680&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:474 > -@property (nonatomic, readonly) UIView *_safeBrowsingWarningForTesting WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); > +@property (nonatomic, readonly) UIView *_safeBrowsingWarning WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); If you're going to 'use it for more than just testing', you need to move it out of the WKTesting category too.
Alex Christensen
Comment 3 2018-11-26 15:07:19 PST
Done! http://trac.webkit.org/r238527
Radar WebKit Bug Importer
Comment 4 2018-11-26 15:08:35 PST
<rdar://problem/46258443>
Note You need to log in before you can comment on or make changes to this bug.