Bug 191981 - Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing
Summary: Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to us...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-26 14:56 PST by Alex Christensen
Modified: 2018-11-26 15:08 PST (History)
2 users (show)

See Also:


Attachments
Patch (7.24 KB, patch)
2018-11-26 14:57 PST, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-11-26 14:56:46 PST
Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing
Comment 1 Alex Christensen 2018-11-26 14:57:44 PST
Created attachment 355680 [details]
Patch
Comment 2 Tim Horton 2018-11-26 14:59:02 PST
Comment on attachment 355680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355680&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:474
> -@property (nonatomic, readonly) UIView *_safeBrowsingWarningForTesting WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> +@property (nonatomic, readonly) UIView *_safeBrowsingWarning WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

If you're going to 'use it for more than just testing', you need to move it out of the WKTesting category too.
Comment 3 Alex Christensen 2018-11-26 15:07:19 PST
Done!
http://trac.webkit.org/r238527
Comment 4 Radar WebKit Bug Importer 2018-11-26 15:08:35 PST
<rdar://problem/46258443>