Bug 191975 - Intersection Observer: rootMargin: '' gives weird results
Summary: Intersection Observer: rootMargin: '' gives weird results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-26 12:13 PST by Simon Fraser (smfr)
Modified: 2018-11-28 07:07 PST (History)
4 users (show)

See Also:

Attachments
Testcase (2.22 KB, text/html)
2018-11-26 12:13 PST, Simon Fraser (smfr) 		no flags Details
Patch (4.39 KB, patch)
2018-11-27 10:22 PST, Ali Juma 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-11-26 12:13:24 PST 
Created attachment 355665 [details]
Testcase

Setting rootMargin to an empty string causes weird behavior (intersection observations in the wrong place). Doesn't happen in Chrome.
Comment 1 Ali Juma 2018-11-27 10:22:11 PST 
Created attachment 355746 [details]
Patch
Comment 2 Ali Juma 2018-11-27 11:08:09 PST 
Upstream PR for the new WPT is https://github.com/web-platform-tests/wpt/pull/14266
Comment 3 Simon Fraser (smfr) 2018-11-27 13:53:24 PST 
Comment on attachment 355746 [details]
Patch

Nice.
Comment 4 WebKit Commit Bot 2018-11-28 07:06:26 PST 
Comment on attachment 355746 [details]
Patch

Clearing flags on attachment: 355746

Committed r238610: <https://trac.webkit.org/changeset/238610>
Comment 5 WebKit Commit Bot 2018-11-28 07:06:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-28 07:07:35 PST 
<rdar://problem/46309082>