Bug 191972 - Move testRunner.toggleCapsLock() to uiController
Summary: Move testRunner.toggleCapsLock() to uiController
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Blocks: 191815
  Show dependency treegraph
Reported: 2018-11-26 10:49 PST by Daniel Bates
Modified: 2018-11-26 12:42 PST (History)
6 users (show)

See Also:

Patch (17.06 KB, patch)
2018-11-26 10:50 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-11-26 10:49:14 PST
Move testRunner.toggleCapsLock() to uiController as uiController is the preferred JavaScript object for UI test functions. Having this functionality be on uiController makes it an asynchronous function naturally and complements use of onkeydown, onkeyup listeners to know when the Caps Lock key event is dispatched. It also facilitates its use directly as part of scripts with other uiController functions invocations that are passed in a single invocation of testRunner.runUIScript().
Comment 1 Daniel Bates 2018-11-26 10:50:29 PST
Created attachment 355654 [details]
Comment 2 Daniel Bates 2018-11-26 12:41:22 PST
Comment on attachment 355654 [details]

Clearing flags on attachment: 355654

Committed r238512: <https://trac.webkit.org/changeset/238512>
Comment 3 Daniel Bates 2018-11-26 12:41:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-11-26 12:42:33 PST