Bug 191965 – CompletionHandler-based async IPC messages only work when the completion handler takes a single argument

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

For instance, in a messages.in file:

SomeMessage() -> () Async

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #0)
> For instance, in a messages.in file:
> 
> SomeMessage() -> () Async

This currently generates an IPC reply invocation like so:

    void SomeMessage::callReply(IPC::Decoder& decoder, CompletionHandler<void()>&& completionHandler)
    {
        completionHandler(WTFMove(*));
    }

[Wenson Hsieh]

Created attachment 355648 [details]
Patch

[Wenson Hsieh]

Comment on attachment 355648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355648&action=review

Thanks for the review!

> Source/WebKit/ChangeLog:3
> +        CompletionHandler-based async IPC messages should support completion handlers that take no arguments

I realized after posting this for review that I forgot to update the ChangeLog here after changing the bug title in Bugzilla. I'll fix the title before landing.

[Wenson Hsieh]

Created attachment 355653 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 355653 [details]
Patch for landing

Clearing flags on attachment: 355653

Committed r238507: <https://trac.webkit.org/changeset/238507>