Bug 191965 - CompletionHandler-based async IPC messages only work when the completion handler takes a single argument
Summary: CompletionHandler-based async IPC messages only work when the completion hand...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2018-11-26 08:44 PST by Wenson Hsieh
Modified: 2018-11-28 13:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (11.25 KB, patch)
2018-11-26 10:09 PST, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (11.25 KB, patch)
2018-11-26 10:49 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-11-26 08:44:28 PST
For instance, in a messages.in file:

SomeMessage() -> () Async
Comment 1 Wenson Hsieh 2018-11-26 09:26:37 PST
(In reply to Wenson Hsieh from comment #0)
> For instance, in a messages.in file:
> 
> SomeMessage() -> () Async

This currently generates an IPC reply invocation like so:

    void SomeMessage::callReply(IPC::Decoder& decoder, CompletionHandler<void()>&& completionHandler)
    {
        completionHandler(WTFMove(*));
    }
Comment 2 Wenson Hsieh 2018-11-26 10:09:58 PST
Created attachment 355648 [details]
Patch
Comment 3 Wenson Hsieh 2018-11-26 10:20:02 PST
Comment on attachment 355648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355648&action=review

Thanks for the review!

> Source/WebKit/ChangeLog:3
> +        CompletionHandler-based async IPC messages should support completion handlers that take no arguments

I realized after posting this for review that I forgot to update the ChangeLog here after changing the bug title in Bugzilla. I'll fix the title before landing.
Comment 4 Wenson Hsieh 2018-11-26 10:49:14 PST
Created attachment 355653 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-11-26 11:55:39 PST
Comment on attachment 355653 [details]
Patch for landing

Clearing flags on attachment: 355653

Committed r238507: <https://trac.webkit.org/changeset/238507>