Bug 191963 – [css-grid] align-self center and position sticky don't work together

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Javier Fernandez]

Created attachment 355631 [details]
Test case to reproduce the issue

What steps will reproduce the problem?
(1) load the attached testcase
(2)
(3)

What is the expected result?
Text that says "I should be centered" should be vertically and horizontally centered in its gray container. 

What happens instead?
The text is horizontally centered, but not vertically centered. It gets rendered at the top of the container.

[Javier Fernandez]

Created attachment 355632 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 355632 [details]
Patch

Thanks, LGTM!

[WebKit Commit Bot]

Comment on attachment 355632 [details]
Patch

Rejecting attachment 355632 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355632, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355632&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=191963&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 355632 from bug 191963.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355632
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/imported/w3c/ChangeLog
	M	LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt
	M	LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt
	M	LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001-expected.txt
	M	LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002-expected.txt
	M	Source/WebCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date
W: fd6691a09a44b18cc3a9f226a17fae20ff84cb4e and refs/remotes/origin/master differ, using rebase:
:040000 040000 c366c5351c006a2c2d56feaccc40eaf0bb6f13bb 3439452ff9ecb7a1215ab1c52b3752481824652a M	LayoutTests
:040000 040000 96ecebf8d390f6cfbc9ea6174ae4830e15957db4 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/imported/w3c/ChangeLog
	M	LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt
	M	LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt
	M	LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001-expected.txt
	M	LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002-expected.txt
	M	Source/WebCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date
W: fd6691a09a44b18cc3a9f226a17fae20ff84cb4e and refs/remotes/origin/master differ, using rebase:
:040000 040000 c366c5351c006a2c2d56feaccc40eaf0bb6f13bb 3439452ff9ecb7a1215ab1c52b3752481824652a M	LayoutTests
:040000 040000 96ecebf8d390f6cfbc9ea6174ae4830e15957db4 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/10164608

[Javier Fernandez]

Created attachment 355723 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 355723 [details]
Patch

Clearing flags on attachment: 355723

Committed r238551: <https://trac.webkit.org/changeset/238551>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46274232>