RESOLVED FIXED 191956
InPlaceAbstractState::endBasicBlock rule for SetLocal should filter the value based on the flush format 
https://bugs.webkit.org/show_bug.cgi?id=191956
Summary InPlaceAbstractState::endBasicBlock rule for SetLocal should filter the value...
Saam Barati
Reported 2018-11-25 18:51:27 PST
Otherwise, we may end up saying that the value the GetLocal loads isn't a subtype of its FlushFormat.
Attachments
patch (4.72 KB, patch)
2018-11-25 19:11 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.57 MB, application/zip)
2018-11-26 09:11 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-11-25 18:51:53 PST
<rdar://problem/45665806>
Saam Barati
Comment 2 2018-11-25 19:11:23 PST
Created attachment 355613 [details] patch
Yusuke Suzuki
Comment 3 2018-11-25 23:06:45 PST
Comment on attachment 355613 [details] patch r=me
EWS Watchlist
Comment 4 2018-11-26 09:11:03 PST
Comment on attachment 355613 [details] patch Attachment 355613 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10154747 New failing tests: media/no-fullscreen-when-hidden.html
EWS Watchlist
Comment 5 2018-11-26 09:11:05 PST
Created attachment 355643 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 6 2018-11-26 12:29:43 PST
Comment on attachment 355613 [details] patch Clearing flags on attachment: 355613 Committed r238511: <https://trac.webkit.org/changeset/238511>
WebKit Commit Bot
Comment 7 2018-11-26 12:29:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.