Bug 191951 - RemoteLayerTreeNode construction cleanups
Summary: RemoteLayerTreeNode construction cleanups
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-11-25 00:58 PST by Antti Koivisto
Modified: 2018-11-25 04:20 PST (History)
6 users (show)

See Also:

patch (19.15 KB, patch)
2018-11-25 01:16 PST, Antti Koivisto
thorton: review+
Details | Formatted Diff | Diff
for landing (19.29 KB, patch)
2018-11-25 03:26 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-11-25 00:58:44 PST
Make it nicer
Comment 1 Antti Koivisto 2018-11-25 01:16:44 PST
Created attachment 355586 [details]
Comment 2 Tim Horton 2018-11-25 01:53:27 PST
Comment on attachment 355586 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=355586&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:64
> +    [layer() setValue:[NSNumber numberWithUnsignedLongLong:layerID] forKey:WKLayerIDPropertyKey];

Can probably just @(layerID) instead of [NSNumber numberWithUnsignedLongLong:layerID]
Comment 3 Antti Koivisto 2018-11-25 03:26:01 PST
Created attachment 355591 [details]
for landing
Comment 4 WebKit Commit Bot 2018-11-25 04:19:12 PST
Comment on attachment 355591 [details]
for landing

Clearing flags on attachment: 355591

Committed r238476: <https://trac.webkit.org/changeset/238476>
Comment 5 WebKit Commit Bot 2018-11-25 04:19:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-25 04:20:32 PST