WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
191942
[ews-app] Add support to get list of Bugzilla patches needing review
https://bugs.webkit.org/show_bug.cgi?id=191942
Summary
[ews-app] Add support to get list of Bugzilla patches needing review
Aakash Jain
Reported
2018-11-24 08:47:02 PST
We should add support to ews-app to get list of Bugzilla patches needing review, so that ews-app can send the patches to Buildbot appropriately. Unfortunately Bugzilla doesn't seems to have a proper REST API to get list of attachment. Tracking that issue in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1508531
We would need to follow webkitpy approach of using BeautifulSoup and parse
http://bugs.webkit.org/request.cgi?action=queue&type=review&group=type
Attachments
Proposed patch
(86.83 KB, patch)
2018-11-26 11:59 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Proposed patch
(85.93 KB, patch)
2018-11-26 12:03 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Updated patch
(5.23 KB, patch)
2018-11-26 20:01 PST
,
Aakash Jain
lforschler
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2018-11-26 11:59:52 PST
Created
attachment 355662
[details]
Proposed patch Part of patch series. Therefore wouldn't apply to ToT without applying other patches first.
Aakash Jain
Comment 2
2018-11-26 12:03:46 PST
Created
attachment 355663
[details]
Proposed patch
Lucas Forschler
Comment 3
2018-11-26 13:10:02 PST
Comment on
attachment 355663
[details]
Proposed patch could we add the BeautifulSoup dependency in a separate patch?
Aakash Jain
Comment 4
2018-11-26 19:52:42 PST
> could we add the BeautifulSoup dependency in a separate patch?
Added in
https://bugs.webkit.org/show_bug.cgi?id=191994
Aakash Jain
Comment 5
2018-11-26 20:01:08 PST
Created
attachment 355706
[details]
Updated patch Updated patch after moving BeautifulSoup code to
https://bugs.webkit.org/show_bug.cgi?id=191994
Aakash Jain
Comment 6
2018-11-28 14:01:02 PST
Committed
r238636
: <
http://trac.webkit.org/changeset/238636
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug