Bug 191942 - [ews-app] Add support to get list of Bugzilla patches needing review
Summary: [ews-app] Add support to get list of Bugzilla patches needing review
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-24 08:47 PST by Aakash Jain
Modified: 2018-11-28 14:01 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (86.83 KB, patch)
2018-11-26 11:59 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Proposed patch (85.93 KB, patch)
2018-11-26 12:03 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Updated patch (5.23 KB, patch)
2018-11-26 20:01 PST, Aakash Jain 		lforschler: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-11-24 08:47:02 PST 
We should add support to ews-app to get list of Bugzilla patches needing review, so that ews-app can send the patches to Buildbot appropriately.

Unfortunately Bugzilla doesn't seems to have a proper REST API to get list of attachment. Tracking that issue in: https://bugzilla.mozilla.org/show_bug.cgi?id=1508531

We would need to follow webkitpy approach of using BeautifulSoup and parse http://bugs.webkit.org/request.cgi?action=queue&type=review&group=type
Comment 1 Aakash Jain 2018-11-26 11:59:52 PST 
Created attachment 355662 [details]
Proposed patch

Part of patch series. Therefore wouldn't apply to ToT without applying other patches first.
Comment 2 Aakash Jain 2018-11-26 12:03:46 PST 
Created attachment 355663 [details]
Proposed patch
Comment 3 Lucas Forschler 2018-11-26 13:10:02 PST 
Comment on attachment 355663 [details]
Proposed patch

could we add the BeautifulSoup dependency in a separate patch?
Comment 4 Aakash Jain 2018-11-26 19:52:42 PST 
> could we add the BeautifulSoup dependency in a separate patch?
Added in https://bugs.webkit.org/show_bug.cgi?id=191994
Comment 5 Aakash Jain 2018-11-26 20:01:08 PST 
Created attachment 355706 [details]
Updated patch

Updated patch after moving BeautifulSoup code to https://bugs.webkit.org/show_bug.cgi?id=191994
Comment 6 Aakash Jain 2018-11-28 14:01:02 PST 
Committed r238636: <http://trac.webkit.org/changeset/238636>