Bug 191936 - Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
Summary: Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-23 18:33 PST by Sam Weinig
Modified: 2018-11-25 21:47 PST (History)
13 users (show)

See Also:


Attachments
Patch (9.45 KB, patch)
2018-11-23 18:44 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (9.46 KB, patch)
2018-11-23 19:34 PST, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2018-11-23 18:33:25 PST
Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
Comment 1 Sam Weinig 2018-11-23 18:44:44 PST Comment hidden (obsolete)
Comment 2 EWS Watchlist 2018-11-23 18:47:23 PST Comment hidden (obsolete)
Comment 3 Sam Weinig 2018-11-23 19:34:35 PST
Created attachment 355551 [details]
Patch
Comment 4 EWS Watchlist 2018-11-23 19:37:38 PST
Attachment 355551 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/ListHashSet.h:639:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/ListHashSet.h:649:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/ListHashSet.h:659:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/ListHashSet.h:666:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/ListHashSet.h:673:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/ListHashSet.h:680:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 6 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 zalan 2018-11-23 21:31:43 PST
Comment on attachment 355551 [details]
Patch

omg, thank you. I've been wanting to do this for months.
Comment 6 Sam Weinig 2018-11-23 21:44:15 PST
(In reply to zalan from comment #5)
> Comment on attachment 355551 [details]
> Patch
> 
> omg, thank you. I've been wanting to do this for months.

Yeah, I saw the FIXME and decided to do it. I have a follow up which fixes the InlineItem list.
Comment 7 WebKit Commit Bot 2018-11-23 22:08:38 PST
Comment on attachment 355551 [details]
Patch

Clearing flags on attachment: 355551

Committed r238467: <https://trac.webkit.org/changeset/238467>
Comment 8 WebKit Commit Bot 2018-11-23 22:08:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-11-23 22:09:27 PST
<rdar://problem/46226142>
Comment 10 Yusuke Suzuki 2018-11-23 22:13:13 PST
Nice!
Comment 11 Ryan Haddad 2018-11-25 21:45:28 PST
One of the API tests added with this change is failing on iOS:

    TestWTF.WTF_ListHashSet.UniquePtrKey_InsertBeforeUsingRawPointer
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp:453
        Expected equality of these values:
          ptrWith2
            Which is: 0x7faee4f03c90
          firstWith4.get()
            Which is: 0x7faee4f03ca0
      
https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/1130/steps/run-api-tests/logs/stdio
Comment 12 Ryan Haddad 2018-11-25 21:47:15 PST
(In reply to Ryan Haddad from comment #11)
> One of the API tests added with this change is failing on iOS:
> 
>     TestWTF.WTF_ListHashSet.UniquePtrKey_InsertBeforeUsingRawPointer
>         
>        
> /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/
> WTF/ListHashSet.cpp:453
>         Expected equality of these values:
>           ptrWith2
>             Which is: 0x7faee4f03c90
>           firstWith4.get()
>             Which is: 0x7faee4f03ca0
>       
> https://build.webkit.org/builders/
> Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/1130/steps/
> run-api-tests/logs/stdio
Oh, I think this was fixed in https://trac.webkit.org/changeset/238486/webkit
Comment 13 zalan 2018-11-25 21:47:50 PST
(In reply to Ryan Haddad from comment #12)
> (In reply to Ryan Haddad from comment #11)
> > One of the API tests added with this change is failing on iOS:
> > 
> >     TestWTF.WTF_ListHashSet.UniquePtrKey_InsertBeforeUsingRawPointer
> >         
> >        
> > /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/
> > WTF/ListHashSet.cpp:453
> >         Expected equality of these values:
> >           ptrWith2
> >             Which is: 0x7faee4f03c90
> >           firstWith4.get()
> >             Which is: 0x7faee4f03ca0
> >       
> > https://build.webkit.org/builders/
> > Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/1130/steps/
> > run-api-tests/logs/stdio
> Oh, I think this was fixed in https://trac.webkit.org/changeset/238486/webkit
Yeah, I fixed it already.