Bug 191935 – [ews-app] Add support to communicate with Buildbot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

ews-app needs to send patches to Buildbot using 'buildbot try' command. We should add that feature.

[Aakash Jain]

Created attachment 355550 [details]
Proposed patch

Part of patch series. Therefore wouldn't apply to ToT without applying other patches first.

[Lucas Forschler]

Comment on attachment 355550 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355550&action=review

> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:44
> +            _log.warn('Error in executing: {}, rc={}'.format(command, return_code))

This should be:
Error executing:
or
Error while executing:

[Kocsen Chung]

Comment on attachment 355550 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355550&action=review

> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:35
> +        command = ['buildbot', 'try', '--connect=pb', '--master={}:{}'.format(config.BUG_SERVER_HOST, config.BUILDBOT_SERVER_PORT),

nit:
Have every `--flag [param]` pair be in it's own new line for readability.

>> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:44
>> +            _log.warn('Error in executing: {}, rc={}'.format(command, return_code))
> 
> This should be:
> Error executing:
> or
> Error while executing:

nit: spell out `rc` => `return code` and have it be on a new line.

[Aakash Jain]

> nit:
> Have every `--flag [param]` pair be in it's own new line for readability.
Sure.

> nit: spell out `rc` => `return code`
Done

> and have it be on a new line.
Tried with and without new line, having on same line seems more readable.

> > This should be:
> > Error executing:
Changed.

[Aakash Jain]

Committed r238535: <http://trac.webkit.org/changeset/238535>

[Radar WebKit Bug Importer]

<rdar://problem/46262314>