We should add a config file to store all the configuration in one place.
Created attachment 355549 [details] Proposed patch Part of patch series. Therefore wouldn't apply to ToT without applying other patches first.
Comment on attachment 355549 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355549&action=review > Tools/BuildSlaveSupport/ews-app/ews/config.py:1 > +# Copyright (C) 2018 Apple Inc. All rights reserved. We should be able to just leverage the Django Settings file: https://docs.djangoproject.com/en/2.1/topics/settings/ Located in: Tools/BuildSlaveSupport/ews-app/settings.py
Committed r238530: <http://trac.webkit.org/changeset/238530>
<rdar://problem/46264850>
> We should be able to just leverage the Django Settings file: We could and I did considered that, but it doesn't look like a clean approach to me. I want to keep the app settings and project settings separate. There are a large number of project settings in Django settings file. Adding this app's configuration there might make it unreadable and hard to find.
> Adding this app's configuration there might make it unreadable and hard to find. I disagree - since Django developers would _expect_ to find these variables in the settings.py file to begin with.