Bug 191929 – [ews-app] Add field in Patch object to indicate if it has been sent to Buildbot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We should add a field in Patch object to indicate if it has been sent to Buildbot. This would help in keeping track of the patch status, and whether the patch needs to be sent to Buildbot or not. For e.g.: if the Patch is downloaded and saved to Database, but 'buildbot try' command failed, there should be a way differentiate that patch in db from another patch which was successfully sent to Buildbot.

Note that in order to trigger builds on multiple builders on Buildbot, ews just needs to execute a single 'buildbot try' command (with appropriate port number). So, one flag (in Patch table) is enough to keep track of whether the patch has been sent to Buildbot or not.

[Aakash Jain]

Created attachment 355547 [details]
Proposed patch

Part of patch series. Therefore wouldn't apply to ToT without applying other patches first.

[Lucas Forschler]

Comment on attachment 355547 [details]
Proposed patch

lgtm. if we refactor bb to buildbot, it will need update here as well.

[Kocsen Chung]

Comment on attachment 355547 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355547&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:38
> +    sent_to_bb = models.BooleanField(default=False)

Ditto from the other patch to expand `bb` to `buildbot`.

> Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:54
>          _log.info('Saved patch in database, id: {}'.format(patchid))

Where does `_log` come from? Is there default Django logging when things save to the DB that we can leverage?

[Aakash Jain]

> Ditto from the other patch to expand `bb` to `buildbot`.
Will expand bb to buildbot.

> Where does `_log` come from? Is there default Django logging when things save to the DB that we can leverage?
Using the python logging. Beginning of this file has: 
_log = logging.getLogger(__name__)

[Aakash Jain]

Committed r238532: <http://trac.webkit.org/changeset/238532>

[Radar WebKit Bug Importer]

<rdar://problem/46261781>