Bug 191927 - Replace LayerOrView typedef with a class
Summary: Replace LayerOrView typedef with a class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-23 09:47 PST by Antti Koivisto
Modified: 2018-11-23 23:18 PST (History)
6 users (show)

See Also:

Attachments
patch (63.01 KB, patch)
2018-11-23 10:05 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (61.24 KB, patch)
2018-11-23 11:49 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (61.25 KB, patch)
2018-11-23 11:56 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-11-23 09:47:13 PST 
This typedef restricts remote layer representation to be either a CA layer or a view. We might want have more flexibility, for example tiles don't really need to be UIViews.
Comment 1 Antti Koivisto 2018-11-23 10:05:51 PST 
Created attachment 355522 [details]
patch
Comment 2 Antti Koivisto 2018-11-23 11:49:16 PST 
Created attachment 355529 [details]
patch
Comment 3 Antti Koivisto 2018-11-23 11:56:30 PST 
Created attachment 355531 [details]
patch
Comment 4 Tim Horton 2018-11-23 13:29:22 PST 
Comment on attachment 355531 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355531&action=review

Seems reasonable.

> Source/WebKit/ChangeLog:9
> +        have more flexibility, for example tiles don't really need to be UIViews. It will also make it easier

If you do make the view-ness optional, please add an ASSERTion that we never parent a view under a raw layer.
Comment 5 WebKit Commit Bot 2018-11-23 23:17:42 PST 
Comment on attachment 355531 [details]
patch

Clearing flags on attachment: 355531

Committed r238468: <https://trac.webkit.org/changeset/238468>
Comment 6 WebKit Commit Bot 2018-11-23 23:17:43 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-23 23:18:26 PST 
<rdar://problem/46226532>