WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
191927
Replace LayerOrView typedef with a class
https://bugs.webkit.org/show_bug.cgi?id=191927
Summary
Replace LayerOrView typedef with a class
Antti Koivisto
Reported
2018-11-23 09:47:13 PST
This typedef restricts remote layer representation to be either a CA layer or a view. We might want have more flexibility, for example tiles don't really need to be UIViews.
Attachments
patch
(63.01 KB, patch)
2018-11-23 10:05 PST
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
patch
(61.24 KB, patch)
2018-11-23 11:49 PST
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
patch
(61.25 KB, patch)
2018-11-23 11:56 PST
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2018-11-23 10:05:51 PST
Created
attachment 355522
[details]
patch
Antti Koivisto
Comment 2
2018-11-23 11:49:16 PST
Created
attachment 355529
[details]
patch
Antti Koivisto
Comment 3
2018-11-23 11:56:30 PST
Created
attachment 355531
[details]
patch
Tim Horton
Comment 4
2018-11-23 13:29:22 PST
Comment on
attachment 355531
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=355531&action=review
Seems reasonable.
> Source/WebKit/ChangeLog:9 > + have more flexibility, for example tiles don't really need to be UIViews. It will also make it easier
If you do make the view-ness optional, please add an ASSERTion that we never parent a view under a raw layer.
WebKit Commit Bot
Comment 5
2018-11-23 23:17:42 PST
Comment on
attachment 355531
[details]
patch Clearing flags on attachment: 355531 Committed
r238468
: <
https://trac.webkit.org/changeset/238468
>
WebKit Commit Bot
Comment 6
2018-11-23 23:17:43 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-11-23 23:18:26 PST
<
rdar://problem/46226532
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug