RESOLVED FIXED191925
[LFC][IFC] Add support for variable height runs. 
https://bugs.webkit.org/show_bug.cgi?id=191925
Summary [LFC][IFC] Add support for variable height runs.
alan
Reported 2018-11-23 08:25:24 PST
ssia
Attachments
Patch (24.02 KB, patch)
2018-11-23 08:32 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-11-23 08:32:04 PST
Created attachment 355516 [details] Patch
alan
Comment 2 2018-11-23 09:05:50 PST
Committed r238460: <https://trac.webkit.org/changeset/238460>
Radar WebKit Bug Importer
Comment 3 2018-11-23 09:06:29 PST
<rdar://problem/46223265>
Ryan Haddad
Comment 4 2018-11-25 22:10:45 PST
The layout test added with this change is failing on iOS: --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/fast/inline/inline-content-with-image-simple-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/fast/inline/inline-content-with-image-simple-actual.txt @@ -5,8 +5,8 @@ RenderBody {BODY} at (8,8) size 784x584 layer at (8,8) size 402x202 clip at (9,9) size 400x200 RenderBlock {DIV} at (0,0) size 402x202 [border: (1px solid #008000)] - RenderText {#text} at (1,83) size 11x26 + RenderText {#text} at (1,83) size 11x25 text run at (1,83) width 11: "1" RenderImage {IMG} at (12,1) size 102x102 [border: (1px solid #FF0000)] - RenderText {#text} at (114,83) size 11x26 + RenderText {#text} at (114,83) size 11x25 text run at (114,83) width 11: "3" https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r238485%20(1146)/results.html It looks like it failed on EWS before this was landed. Would you please rebaseline it if needed?
alan
Comment 5 2018-11-26 07:33:19 PST
(In reply to Ryan Haddad from comment #4) > The layout test added with this change is failing on iOS: > --- > /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test- > results/fast/inline/inline-content-with-image-simple-expected.txt > +++ > /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test- > results/fast/inline/inline-content-with-image-simple-actual.txt > @@ -5,8 +5,8 @@ > RenderBody {BODY} at (8,8) size 784x584 > layer at (8,8) size 402x202 clip at (9,9) size 400x200 > RenderBlock {DIV} at (0,0) size 402x202 [border: (1px solid #008000)] > - RenderText {#text} at (1,83) size 11x26 > + RenderText {#text} at (1,83) size 11x25 > text run at (1,83) width 11: "1" > RenderImage {IMG} at (12,1) size 102x102 [border: (1px solid #FF0000)] > - RenderText {#text} at (114,83) size 11x26 > + RenderText {#text} at (114,83) size 11x25 > text run at (114,83) width 11: "3" > > https://build.webkit.org/results/ > Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r238485%20(1146)/ > results.html > > It looks like it failed on EWS before this was landed. Would you please > rebaseline it if needed? https://trac.webkit.org/changeset/238494/webkit
Note You need to log in before you can comment on or make changes to this bug.