Bug 19192 - remove NPNVpluginEventModel, fix example plugin
Summary: remove NPNVpluginEventModel, fix example plugin
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2008-05-22 08:29 PDT by Josh Aas
Modified: 2008-05-22 11:29 PDT (History)
0 users

See Also:

fix v1.0 (2.16 KB, patch)
2008-05-22 08:30 PDT, Josh Aas
no flags Details | Formatted Diff | Diff
fix v1.1 (3.18 KB, patch)
2008-05-22 08:32 PDT, Josh Aas
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Aas 2008-05-22 08:29:30 PDT
There is really no reason for anyone to get the NPNVpluginEventModel variable, the plugin should know it and it gives the illusion that there could be some disagreement with its NPPV sibling. Its existence is confusing and leads to bugs like the Cocoa event plugin mistakenly using it in a SetValue call.
Comment 1 Josh Aas 2008-05-22 08:30:11 PDT
Created attachment 21293 [details]
fix v1.0
Comment 2 Josh Aas 2008-05-22 08:32:52 PDT
Created attachment 21294 [details]
fix v1.1

Also fix the drawing models plugin.
Comment 3 Anders Carlsson 2008-05-22 11:17:11 PDT
Comment 4 Anders Carlsson 2008-05-22 11:28:53 PDT
Comment on attachment 21294 [details]
fix v1.1

Needs a ChangeLog, but I took care of that.
Comment 5 Anders Carlsson 2008-05-22 11:29:02 PDT
Committed revision 34026.