Bug 191917 - [Cocoa] clang emits a warning when building WebKit after r238293
Summary: [Cocoa] clang emits a warning when building WebKit after r238293
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-22 18:57 PST by Wenson Hsieh
Modified: 2018-11-22 20:02 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.97 KB, patch)
2018-11-22 19:03 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-11-22 18:57:41 PST
This is the warning:

CompileC WKShareSheet.o
Ld WebKit
ld: warning: instance method 'isSafeBrowsingEnabled' in category from /Users/whsieh/Build/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource17-mm.o overrides method from class in /Users/whsieh/Build/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource17-mm.o
ld: warning: instance method 'setSafeBrowsingEnabled:' in category from /Users/whsieh/Build/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource17-mm.o overrides method from class in /Users/whsieh/Build/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource17-mm.o
PhaseScriptExecution Check For Weak VTables and Externals
PhaseScriptExecution Check For Inappropriate Objective-C Class Names

...it looks like both -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled are implemented in the WKPrivate category, but should instead be implemented in the main category.
Comment 1 Wenson Hsieh 2018-11-22 19:03:56 PST
Created attachment 355495 [details]
Patch
Comment 2 WebKit Commit Bot 2018-11-22 20:00:38 PST
Comment on attachment 355495 [details]
Patch

Clearing flags on attachment: 355495

Committed r238455: <https://trac.webkit.org/changeset/238455>
Comment 3 WebKit Commit Bot 2018-11-22 20:00:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-11-22 20:02:17 PST
<rdar://problem/46217146>